async_write_some() with a zero size buffer is well defined. Fixing #23

TorstenRobitzki · Apr 25, 2016 · bd7637e · bd7637e
1 parent 2ea38a1
commit bd7637e
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/source/asio_mocks/test_socket.h b/source/asio_mocks/test_socket.h
@@ -1025,6 +1025,12 @@ void socket<Iterator, Timer, Trait>::impl::async_write_some(
         return;
     }
 
+    if ( boost::asio::buffer_size( buffers ) == 0 )
+    {
+        io_service_.post(boost::bind<void>(handler, boost::system::error_code(), 0));
+        return;
+    }
+
     if ( !write_plan_.empty() )
     {
         const write_plan::item item = write_plan_.next_write();

diff --git a/source/asio_mocks/test_socket_test.cpp b/source/asio_mocks/test_socket_test.cpp
@@ -412,3 +412,22 @@ BOOST_AUTO_TEST_CASE( reading_into_a_zero_byte_buffer )
     BOOST_CHECK( result.called );
     BOOST_CHECK_EQUAL( result.bytes_transferred, 0 );
 }
+
+BOOST_AUTO_TEST_CASE( writing_from_zero_byte_buffer )
+{
+    asio_mocks::io_completed result;
+
+    boost::asio::io_service         queue;
+    asio_mocks::socket<const char*> sock( queue, begin(simple_get_11), end(simple_get_11) );
+    const char                      buf = 0x42;
+
+    sock.async_write_some(
+        boost::asio::buffer( &buf, 0 ),
+        result );
+
+    tools::run( queue );
+
+    BOOST_CHECK( !result.error );
+    BOOST_CHECK( result.called );
+    BOOST_CHECK_EQUAL( result.bytes_transferred, 0 );
+}