Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command Timeout is not being honored in PostgreSQL and MySQL #490

Closed
Grauenwolf opened this issue Jul 12, 2022 · 0 comments
Closed

Command Timeout is not being honored in PostgreSQL and MySQL #490

Grauenwolf opened this issue Jul 12, 2022 · 0 comments

Comments

@Grauenwolf
Copy link
Collaborator

The code that allows for overriding the command timeout was not being executed for PostgreSQL and MySQL.

At one point we switched to using ExecutionToken.PopulateCommand to set the parameters for a command. At first glance, this looks like just a code deduplication effort. But it also calls OnBuildCommand(command) and RaiseCommandBuilt(command);. This event pipeline allow appenders such as TimeoutAppender to modify the command.

Since PostgreSQL and MySQL were manually populating the command instead of calling ExecutionToken.PopulateCommand, they were not participating in the above mentioned event pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant