Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_config should identify loops in proxy mode #11

Open
Torxed opened this issue Jul 16, 2020 · 1 comment
Open

check_config should identify loops in proxy mode #11

Torxed opened this issue Jul 16, 2020 · 1 comment

Comments

@Torxed
Copy link
Owner

Torxed commented Jul 16, 2020

If a vhost is set to proxy mode, and where the proxy target/endpoint is 127.0.0.1:443, slimHTTP will hang indefinitely due to the lack of threads. Since slimHTTP will connect to the proxy (self), and wait for data as it's not part of the main event loop (yet).
Which means that slimHTTP can't process the incoming client request from itself - and thus hang.

the HTTP_PROXY_REQUEST should be part of the main event poller, although I'm not sure how to wrap it in there just yet.
So for now, let check_config find and warn/raise an issue when the proxy config points to a listening address/session of itself.

Torxed added a commit that referenced this issue Jul 16, 2020
A very simple/crude reverse proxy has been created. It does not scale, but works for smaller stuff.

See issue #11 for more information on some of the limitations.
@Torxed Torxed removed the bug label Jul 16, 2020
@Torxed
Copy link
Owner Author

Torxed commented Oct 7, 2020

The PROXY object should probably behave the same way as STREAM_CHUNKED behaves where the object is yielded and saved in a session, so that data can be fetched/sent in "chunks" if need be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant