Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update headers on create video #29

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Update headers on create video #29

merged 1 commit into from
Aug 17, 2022

Conversation

hcaz
Copy link
Contributor

@hcaz hcaz commented Aug 15, 2022

This is to address #28. However should all POST endpoints have this header included to be accepted by BunnyCDN, and should this be across all endpoint stores such as collection, or even the edge storage?

@ToshY
Copy link
Owner

ToshY commented Aug 16, 2022

Hey @hcaz 👋

First off, thanks for the PR 👍

Regarding your question if the header should be added to the other endpoints, they already are added for the requests at the Stream API for creating and updating collection. For the Edge Storage API, there don't seem to be any POST endpoints. And I've also checked the rest of base API endpoints in the documentation to see if they possibly could have this header, but those just seem to have application/json.

Anyway, if you found an endpoint that should have this header as well and it's currently missing, let me know. Else we can continue with merging and I can tag a new release.

@ToshY ToshY self-requested a review August 16, 2022 18:29
@hcaz
Copy link
Contributor Author

hcaz commented Aug 17, 2022

Looked through the docs a bit closer and I think it is just the 'create video' that's missing the correct headers. Everything else looks good 👍

@ToshY ToshY merged commit 1f4f2e7 into ToshY:master Aug 17, 2022
@hcaz hcaz deleted the patch-1 branch August 17, 2022 17:40
@ToshY
Copy link
Owner

ToshY commented Aug 17, 2022

@hcaz Tagged 2.3.1

@hcaz
Copy link
Contributor Author

hcaz commented Aug 17, 2022

Awesome, cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants