Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate the profile recovery feature #603

Open
Solanya opened this issue May 30, 2022 · 0 comments
Open

Investigate the profile recovery feature #603

Solanya opened this issue May 30, 2022 · 0 comments
Assignees
Labels
Milestone

Comments

@Solanya
Copy link
Member

Solanya commented May 30, 2022

Back when chat links were implemented, profile chat links had the option to import it to help recover a profile if it was lost after data loss but still present in someone else's directory. I'm unsure if this feature ever worked properly, but it currently doesn't for a couple of reasons:

  • A check was added to ensure the player importing the profile actually made the profile (to avoid facilitating impersonation). However, that check was incorrect and checks the sender instead of the receiver.
  • The profile that would be sent would have the structure of a profile stored in the directory instead of a profile of your own. The structure has differences which will cause Lua errors if copied strictly, so it needs to be converted upon import.

It would be good to see if both of these issues could be fixed to make it possible to retrieve your profiles from someone else easily.

@Solanya Solanya added the bug label May 30, 2022
@Solanya Solanya added this to the 2.4 milestone May 30, 2022
@Solanya Solanya self-assigned this May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant