Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessing variables in Object with key containing a dot #23

Closed
tatarysh opened this issue Nov 24, 2023 · 3 comments
Closed

Accessing variables in Object with key containing a dot #23

tatarysh opened this issue Nov 24, 2023 · 3 comments

Comments

@tatarysh
Copy link
Contributor

I encountered an issue related to accessing variables within an object where the key contains a dot. The logical query looks like this:

{
    "var": "hello.world"
}

And the payload is:

{
    "hello": {
        "world": "i'm here!"
    },
    "hello.world": "ups!"
}

Currently, there is no access to the hello.world variable. I believe it would be beneficial to adopt the convention used in the dot-prop package, where access to such a key is possible by including a double backslash before the dot in the key. Therefore, for the mentioned query, it should look like this:

{
    "var": "hello\\.world"
}
@TotalTechGeek
Copy link
Owner

TotalTechGeek commented Nov 24, 2023

Hey @tatarysh, I believe I've seen this issue pop up before in the original json-logic-js repo:
jwadhams/json-logic-js#127

And semi-related:
jwadhams/json-logic-js#110

The suggestion to use the dot-prop convention is a solid recommendation.

I may take a peek into issue 110 from json-logic-js with a bit more intent after merging this in.

TotalTechGeek added a commit that referenced this issue Nov 24, 2023
@TotalTechGeek
Copy link
Owner

Hi, I've published 1.3.0 to introduce the escape syntax for paths.

Please let me know if you run into any issues / have any recommendations! (I will need to update the documentation to include this information)

@tatarysh
Copy link
Contributor Author

great job, thanks 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants