-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converted CommonJs to ESM #2
Conversation
Hey, thank you for the MR @sphinxc0re! I will try to review and merge this sometime this weekend. On Prettier, my usage of standard is more based on tradition rather than a strong preference for it, I would be open to considering a switch to a more common style. I do have a slight preference for the Since Node v12 is still in Maintenance LTS, I would like to continue supporting it until it EOLs in April of 2022. Aside from that, thank you a ton for your contribution! |
Wow! I didn't think this would be the reaction 馃槷 Okay, let's go through this step-by-step:
|
@TotalTechGeek Is the coverage drop a problem? I didn't really add anything that is untested 馃 |
@TotalTechGeek Nice! Thanks for letting me contribute! Would you mind publishing a new version to npm? |
I will soon! Just running through some final steps (correcting some minor linting here & there with typescript, making some of the imports more consistent) |
@sphinxc0re Hi, 1.1.8 has been released. The module should be able to support both CJS (via Rollup) & ESM environments, with ESM being the default. |
Woohoo! 馃槂 |
Okay, I don't expect you to merge this at any point in time since I didn't ask you whether this change was something you wanted in the first place. I totally get that. Also, this is something I threw together in an afternoon. Anyway, here is what I did:
Ran prettier for a unified code standardI guess, you can look at this PR as more of a suggestion, rather than an actual PR. It is immensely opinionated
and as you can probably tell I'm using prettier, which this project did not adopt as far, as I can see.closes #1