Improve Permissive Implementation; Allows Data Detection Override #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion in #28, I decided to improve how the Permissive implementation is handled to allow users to better customize how the data detection is implemented.
I do realize that as I add these capabilities, we might be making it slightly more difficult to maintain a fully compatible cross-language json-logic ecosystem, however, I'm comfortable supporting some of these extensions as long as it is clear to folks that these behaviors might not translate to other libraries by other authors.
Anyway:
I've changed the engine implementation to allow a user to specify how "data" is detected in one's logic.
You can extend logic engine and implement an
isData
method to specify if an object embedded in the logic should be treated as data, rather than treating it as a command.This should give developers full flexibility in how they believe this should work, as there will be different opinions:
Etc.