feat(socketioxide): disconnect handler #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…ince there were only `write()` calls
The `on_disconnect` fn will then be called with the reason in param.
This was referenced Jul 2, 2023
Totodore
changed the title
Totodore
changed the title
|
Is there currently (in version 0.3.0) at least a way to check, whether a given socket is open or closed? (I don't see any.) |
- remove `thiserror::Error` from `DisconnectReason` - remove `HttpTransport` error from the `engineioxide::errors::Error` struct
socketioxide/src/client.rs
Outdated
| ); | ||
| socket.close(); | ||
| let reason: Option<EIoDisconnectReason> = err.into(); | ||
| reason.map(|reason| socket.close(reason)); |
Check warning
Code scanning / clippy
called map(f) on an Option value where f is a closure that returns the unit type () Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no way for the end user to execute code when the socket is disconnected.
Now, it will be possible to add an handler executed when the socket is disconnected:
There will be a
DisconnectReasonenum provided so the user knows what caused the disconnect event.Steps :
on_disconnecthandler on socketioxideSocket.DisconnectReasonon engineioxideDisconnectReasonon socketioxideErrors provided forTransportErrorvariant on theDisconnectReason