Passing schema with id to TypeInfo and ConfluentKafkaAvroDeserializer #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or further optimizations
arkadius
changed the title
lciolecki
reviewed
Nov 13, 2020
| } | ||
|
|
||
| object RuntimeSchemaData { | ||
| def apply(schema: Schema, idOpt: Option[Int]): RuntimeSchemaData = |
There was a problem hiding this comment.
consistently schemaIdOpt ?
| * It is lightened version of Confluent's SchemaMetadata. We don't want to use their class, because our SchemaRegistryClient | ||
| * is not coupled with concrete schema registry implementation. | ||
| */ | ||
| case class SchemaWithMetadata(schema: Schema, id: Int) |
There was a problem hiding this comment.
- If we have
RuntimeSchemaDatathen maybe better name will be justSchemaData? - Hmm, I think about add there version: Option[Int]?
There was a problem hiding this comment.
Ad 1. I want to has similar naming as Confluent does. IMO it is no need to make it looks similar like RuntimeSchemaData because there are for other purposes.
Ad 2. For now YAGNI, there is many other fields that we can have here, but IMO we shouldn't put all because we don't know how looks like other schema registry implementations. Take a look on full confluent's SchemaMetada:
private int id;
private int version;
private String schemaType;
private String schema;
private List<SchemaReference> references;
| val buffer = ConfluentUtils.parsePayloadToByteBuffer(payload).valueOr(ex => throw ex) | ||
| read(buffer, readerSchema) | ||
| } | ||
|
|
||
| protected def read(buffer: ByteBuffer, expectedSchema: Schema): AnyRef = { | ||
| protected def read(buffer: ByteBuffer, expectedSchema: RuntimeSchemaData): AnyRef = { |
There was a problem hiding this comment.
readerSchema -> readerSchemaData
There was a problem hiding this comment.
Fixed in all places. You don't need to add comments in all places ;)
.../schemaregistry/confluent/serialization/ConfluentKafkaAvroDeserializationSchemaFactory.scala
Outdated
Show resolved
Hide resolved
.../schemaregistry/confluent/serialization/ConfluentKafkaAvroDeserializationSchemaFactory.scala
Outdated
Show resolved
Hide resolved
.../schemaregistry/confluent/serialization/ConfluentKafkaAvroDeserializationSchemaFactory.scala
Outdated
Show resolved
Hide resolved
...cker/engine/avro/schemaregistry/confluent/serialization/ConfluentKafkaAvroDeserializer.scala
Outdated
Show resolved
Hide resolved
...la/pl/touk/nussknacker/engine/avro/serialization/KafkaAvroDeserializationSchemaFactory.scala
Outdated
Show resolved
Hide resolved
lciolecki
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… for further optimizations