Exception handler accessible via custom node context #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedrz
force-pushed
the
exception-handler
branch
8 times, most recently
from
6255ae1
to
c493efd
Compare
mproch
reviewed
Dec 4, 2020
| private val exceptionHandlerPreparer = flinkNodeContext.exceptionHandlerPreparer | ||
| private var exceptionHandler: FlinkEspExceptionHandler = _ | ||
|
|
||
| override def open(parameters: Configuration): Unit = { |
There was a problem hiding this comment.
can we extract it to some common method? Or is it tricky because of multiinheritance?
There was a problem hiding this comment.
Extracted to helper trait.
...link/avro-util/src/test/scala/pl/touk/nussknacker/engine/avro/RecodingExceptionHandler.scala
Outdated
Show resolved
Hide resolved
...ess/src/main/scala/pl/touk/nussknacker/engine/process/compiler/CompiledProcessWithDeps.scala
Show resolved
Hide resolved
...ess/src/main/scala/pl/touk/nussknacker/engine/process/compiler/CompiledProcessWithDeps.scala
Show resolved
Hide resolved
jedrz
force-pushed
the
exception-handler
branch
from
ab0fbf1
to
5f6ea75
Compare
gadomsky
reviewed
Dec 8, 2020
...main/scala/pl/touk/nussknacker/engine/flink/api/exception/WithFlinkEspExceptionHandler.scala
Show resolved
Hide resolved
mproch
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report events that could not be encoded to Avro.