Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Window manager #1706

Merged
merged 35 commits into from Sep 2, 2021
Merged

Window manager #1706

merged 35 commits into from Sep 2, 2021

Conversation

JulianWielga
Copy link
Member

new window manager (not only modals) including:

  • move windows - safe from screen overflow
  • resize windows - with zoom/restore button, dblclick on header, drag to top
  • keyboard access to buttons and focus trap inside window
  • close by esc (hook for pressed keys used in nodes selection)
  • opened windows metadata in store - possible multiple windows of same type if needed
  • z index handling when multiple

preview done only on "add process" with only minor visual changes.

Zrzut ekranu 2021-05-28 o 13 48 25

@dswiecki
Copy link
Collaborator

Are we waiting here ?

@JulianWielga JulianWielga force-pushed the window-manager branch 6 times, most recently from 44866c7 to e1e7ce4 Compare August 25, 2021 16:36
@dswiecki dswiecki marked this pull request as ready for review August 30, 2021 12:12
@mproch
Copy link
Collaborator

mproch commented Sep 1, 2021

Things to fix:

  • font size is not consistent:
    Screenshot from 2021-09-01 12-08-22
  • font color is somwhat different,

Screenshot from 2021-09-01 12-09-25

Screenshot from 2021-09-01 12-09-39

==> new version seems blurry

@dswiecki
Copy link
Collaborator

dswiecki commented Sep 1, 2021

NodeDetailsModalHeader.js is empty

dswiecki
dswiecki reviewed Sep 1, 2021
View reviewed changes
ui/client/components/graph/node-modal/subprocess-input-definition/DndItems.tsx Show resolved Hide resolved
ui/client/components/modals/ProcessDialogWarnings.tsx Show resolved Hide resolved
ui/client/windowManager/LaddaButton.tsx Outdated Show resolved Hide resolved
ui/client/stylesheets/graph.styl Outdated Show resolved Hide resolved
ui/client/stylesheets/graph.styl Outdated Show resolved Hide resolved
ui/client/http/HttpService.ts Show resolved Hide resolved
arkadius
arkadius reviewed Sep 1, 2021
View reviewed changes
ui/client/components/graph/node-modal/NodeDetailsContent.js Outdated Show resolved Hide resolved
ui/client/components/graph/PanZoomPlugin.ts Show resolved Hide resolved
ui/client/package.json Outdated Show resolved Hide resolved
@JulianWielga JulianWielga merged commit 431e1e1 into TouK:staging Sep 2, 2021
@mproch mproch mentioned this pull request Sep 6, 2021
Closed
This was referenced Sep 9, 2021
Closed
Closed
Closed
@dswiecki dswiecki added this to the 1.0.0 milestone Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkadius arkadius arkadius approved these changes

@dswiecki dswiecki dswiecki approved these changes

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JulianWielga @dswiecki @mproch @arkadius