Kafka universal unconfluentization #3948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
arkadius
commented
Jan 25, 2023
•
arkadius
commented
- Using confluent abstractions only when needed
- Non-confluent classes renamed and moved to desired packages
- Removed some duplication of code in: universal record fromatter implementation and AvroSchemaEvolution
- Extracted new class: SchemaIdFromMessageExtractor to make Confluent logic explicit and moved to top level
- Extracted SchemaValidator to make Confluent logic explicit and be able to compose
- Some renames: ConsumerRecordUtils -> KafkaRecordUtils
- RecordDeserializer -> AvroRecordDeserializer (also inheritance replaced by composition)
- (De)SerializerFactory - easier abstractions
- Performance fix: UniversalKafkaSource now produce GenericRecordWithSchemaId
- AvroSerializerRegistrar fixes: wasn't checked if component is a kafka component, bad path was used (config.kafka instead of kafka)
- ConfluentSchemaRegistryFactory is not necessary now - removed
- ConfluentSchemaBasedSerdeProvider.universal replaced by UniversalSchemaBasedSerdeProvider.create
|
created: #3950 |
arkadius
force-pushed
the
kafka-universal-unconfluentization
branch
from
d3aa693
to
26875f1
Compare
|
updated: #3950 |
arkadius
force-pushed
the
kafka-universal-unconfluentization
branch
10 times, most recently
from
6104545
to
572745a
Compare
arkadius
force-pushed
the
kafka-universal-unconfluentization
branch
from
8f97d6e
to
fb76db1
Compare
arkadius
force-pushed
the
kafka-universal-unconfluentization
branch
2 times, most recently
from
8b191e5
to
7b79ea1
Compare
gadomsky
reviewed
Jan 30, 2023
.../schemaregistry/confluent/schemaid/SchemaIdFromNuHeadersAndPotentiallyConfluentPayload.scala
Outdated
Show resolved
Hide resolved
arkadius
force-pushed
the
kafka-universal-unconfluentization
branch
from
c774296
to
d3be1bd
Compare
gadomsky
reviewed
Jan 30, 2023
...a/pl/touk/nussknacker/engine/schemedkafka/schemaregistry/universal/ParsedSchemaSupport.scala
Outdated
Show resolved
Hide resolved
...a/pl/touk/nussknacker/engine/schemedkafka/schemaregistry/universal/ParsedSchemaSupport.scala
Outdated
Show resolved
Hide resolved
arkadius
force-pushed
the
kafka-universal-unconfluentization
branch
from
414c9b0
to
57982ee
Compare
- Using confluent abstractions only when needed - Non-confluent classes renamed and moved to desired packages - Removed some duplication of code in: universal record fromatter implementation and AvroSchemaEvolution - Extracted new class: SchemaIdFromMessageExtractor to make Confluent logic explicit and moved to top level - Extracted SchemaValidator to make Confluent logic explicit and be able to compose - Some renames: ConsumerRecordUtils -> KafkaRecordUtils - RecordDeserializer -> AvroRecordDeserializer (also inheritance replaced by composition) - (De)SerializerFactory - easier abstractions - Performance fix: UniversalKafkaSource now produce GenericRecordWithSchemaId - AvroSerializerRegistrar fixes: wasn't checked if component is a kafka component, bad path was used (config.kafka instead of kafka) - ConfluentSchemaRegistryFactory is not necessary now - removed - ConfluentSchemaBasedSerdeProvider.universal replaced by UniversalSchemaBasedSerdeProvider.create
…(currently only Confluent is handled)
arkadius
force-pushed
the
kafka-universal-unconfluentization
branch
from
b7970ec
to
28f046c
Compare
arkadius
force-pushed
the
kafka-universal-unconfluentization
branch
6 times, most recently
from
265c113
to
ce1d672
Compare
arkadius
force-pushed
the
kafka-universal-unconfluentization
branch
2 times, most recently
from
6a77674
to
a922f76
Compare
…nfluent implementation dependant
arkadius
force-pushed
the
kafka-universal-unconfluentization
branch
from
a922f76
to
20957cc
Compare
gadomsky
reviewed
Jan 31, 2023
engine/flink/tests/src/test/scala/pl/touk/nussknacker/defaultmodel/StateCompatibilityTest.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.