Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local development doesn't resolve evn variables in config passed into execution #4030

Merged
merged 1 commit into from Feb 24, 2023

Conversation

arkadius
Copy link
Member

No description provided.

@arkadius arkadius changed the title Keep modelConfig unresolved until the moment of deployment Local development doesn't load input model config passed into execution Feb 23, 2023
@arkadius arkadius marked this pull request as ready for review February 23, 2023 16:12
@arkadius arkadius force-pushed the model-config-unresolved branch 2 times, most recently from 3a4c59a to 516c7db Compare February 23, 2023 18:59
@github-actions
Copy link
Contributor

created: #4034

@github-actions
Copy link
Contributor

updated: #4034

… execution.

Thanks to that it is possible to have other kafka / schema registry location on designer side than on Flink side
@arkadius arkadius changed the title Local development doesn't load input model config passed into execution Local development doesn't resolve evn variables in config passed into execution Feb 24, 2023
Copy link
Collaborator

@gadomsky gadomsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkadius arkadius merged commit 782eb67 into staging Feb 24, 2023
@coutoPL coutoPL deleted the model-config-unresolved branch August 17, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants