New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM ProcessState caching #4104
Merged
Merged
DM ProcessState caching #4104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkadius
force-pushed
the
process-state-caching
branch
4 times, most recently
from
March 14, 2023 14:08
c99b348
to
f636f10
Compare
jedrz
approved these changes
Mar 14, 2023
gadomsky
approved these changes
Mar 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...manager-api/src/main/scala/pl/touk/nussknacker/engine/api/deployment/DeploymentManager.scala
Outdated
Show resolved
Hide resolved
...a/pl/touk/nussknacker/engine/api/deployment/cache/CachingProcessStateDeploymentManager.scala
Show resolved
Hide resolved
gadomsky
reviewed
Mar 15, 2023
.../server/src/main/scala/pl/touk/nussknacker/ui/process/deployment/DeploymentServiceImpl.scala
Show resolved
Hide resolved
gadomsky
approved these changes
Mar 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
arkadius
force-pushed
the
process-state-caching
branch
from
March 20, 2023 09:42
35d0d19
to
3bfe006
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.