New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine statuses Failing, Failed, Error, Warning, FailedToGet and MulipleJobsRunning into one "Problem" #4132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gskrobisz
changed the base branch from
staging
to
improvement/filtering_by_status_part2
March 19, 2023 16:33
gskrobisz
changed the title
Combine statuses Failed, Error and FailedToGet
Combine statuses Failed, Error, Warning and FailedToGet
Mar 19, 2023
gskrobisz
force-pushed
the
improvement/filtering_by_status_part3
branch
from
March 19, 2023 16:36
9b1d940
to
79ea8ce
Compare
gskrobisz
force-pushed
the
improvement/filtering_by_status_part3
branch
from
March 19, 2023 17:44
79ea8ce
to
34763d0
Compare
gskrobisz
changed the title
Combine statuses Failed, Error, Warning and FailedToGet
Combine statuses Failing, Failed, Error, Warning and FailedToGet
Mar 19, 2023
gskrobisz
force-pushed
the
improvement/filtering_by_status_part3
branch
2 times, most recently
from
March 21, 2023 00:33
0fb6850
to
3c29026
Compare
gskrobisz
changed the base branch from
improvement/filtering_by_status_part2
to
staging
March 21, 2023 00:33
gskrobisz
changed the title
Combine statuses Failing, Failed, Error, Warning and FailedToGet
Combine statuses Failing, Failed, Error, Warning, FailedToGet and MulipleJobsRunning into one "Problem"
Mar 21, 2023
gskrobisz
force-pushed
the
improvement/filtering_by_status_part3
branch
from
March 21, 2023 12:09
99516dd
to
6074c4c
Compare
…into one dynamic "Problem" status.
gskrobisz
force-pushed
the
improvement/filtering_by_status_part3
branch
from
March 21, 2023 12:12
6074c4c
to
b655ab0
Compare
arkadius
reviewed
Mar 21, 2023
...cala/pl/touk/nussknacker/engine/api/deployment/OverridingProcessStateDefinitionManager.scala
Show resolved
Hide resolved
arkadius
approved these changes
Mar 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
gadomsky
approved these changes
Mar 22, 2023
lciolecki
reviewed
Mar 22, 2023
...-api/src/main/scala/pl/touk/nussknacker/engine/api/deployment/simple/SimpleStateStatus.scala
Show resolved
Hide resolved
lciolecki
reviewed
Mar 22, 2023
...-api/src/main/scala/pl/touk/nussknacker/engine/api/deployment/simple/SimpleStateStatus.scala
Outdated
Show resolved
Hide resolved
lciolecki
reviewed
Mar 22, 2023
lciolecki
reviewed
Mar 22, 2023
...flink/management/src/main/scala/pl/touk/nussknacker/engine/management/FlinkStateStatus.scala
Show resolved
Hide resolved
lciolecki
reviewed
Mar 22, 2023
...oymentManager/src/main/scala/pl/touk/nussknacker/k8s/manager/K8sDeploymentStatusMapper.scala
Show resolved
Hide resolved
lciolecki
approved these changes
Mar 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I left some mirror comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
ProblemStateStatus
.SimpleStateStatus.Undefined
.Other changes:
delegate
inOverridingProcessStateDefinitionManager
now has no default value. For clarity it should be provided explicitly.To discuss / hint needed:
ProblemStateStatus
.ProblemStateStatus
outside ofSimpleStateStatus
.Issues moved to another PR
6. StateStatus.isDuringDeploy can be replaced with pattern match with DuringDeployStateStatus, we do not need this at StateStatus level.
7. ProcessState.isDeployed - why during deploy is recognized as deployed?