New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NU-1094] Cats Effect 3 bump #4287
Conversation
5f16b1d
to
ddfe7f0
Compare
a2c2947
to
dc0291d
Compare
150106b
to
87c6d4b
Compare
aba88c8
to
d62419e
Compare
b651a3e
to
72c623f
Compare
I think I managed to fix the problem found by FlinkTestMainSpec. Currently, this test is for the |
...src/main/scala/pl/touk/nussknacker/engine/util/SynchronousExecutionContextAndIORuntime.scala
Outdated
Show resolved
Hide resolved
@lciolecki can you recheck performance after these changes? |
Based on the code of benchmarks we have, I think the previous implementation I pushed is not correct. It looks like we don't have good tests that cover the functionality we touch in this PR. Moreover, it looks like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
I leaved a few minor comments.
Please, squash before merge 😄
...src/main/scala/pl/touk/nussknacker/engine/process/registrar/SyncInterpretationFunction.scala
Outdated
Show resolved
Hide resolved
...pi/src/main/scala/pl/touk/nussknacker/engine/api/process/AsyncExecutionContextPreparer.scala
Outdated
Show resolved
Hide resolved
designer/server/src/main/scala/pl/touk/nussknacker/ui/server/NussknackerHttpServer.scala
Outdated
Show resolved
Hide resolved
...src/main/scala/pl/touk/nussknacker/engine/util/SynchronousExecutionContextAndIORuntime.scala
Outdated
Show resolved
Hide resolved
...src/main/scala/pl/touk/nussknacker/engine/util/SynchronousExecutionContextAndIORuntime.scala
Show resolved
Hide resolved
Piotr is absent. His comments were addressed.
Describe your changes
FlinkTestMainSpec
Benchmarks
Before
After
Checklist before merge