Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expression suggestions with Typer #4323

Merged
merged 6 commits into from Jun 13, 2023
Merged

Expression suggestions with Typer #4323

merged 6 commits into from Jun 13, 2023

Conversation

bartektartanus
Copy link
Contributor

No description provided.

@bartektartanus bartektartanus force-pushed the expression-suggestions-with-typer branch from 4952e48 to 971914b Compare May 30, 2023 12:33
@github-actions github-actions bot added the docs label May 30, 2023
@github-actions github-actions bot mentioned this pull request May 30, 2023
Merged
@github-actions
Copy link
Contributor

created: #4340

arkadius
arkadius reviewed May 30, 2023
View reviewed changes
designer/server/src/main/scala/pl/touk/nussknacker/ui/api/ExpressionSuggester.scala Outdated Show resolved Hide resolved
interpreter/src/main/scala/pl/touk/nussknacker/engine/spel/SpelExpressionSuggester.scala Outdated Show resolved Hide resolved
interpreter/src/main/scala/pl/touk/nussknacker/engine/spel/SpelExpressionSuggester.scala Outdated Show resolved Hide resolved
interpreter/src/main/scala/pl/touk/nussknacker/engine/spel/SpelExpressionSuggester.scala Outdated Show resolved Hide resolved
interpreter/src/main/scala/pl/touk/nussknacker/engine/spel/SpelExpressionSuggester.scala Outdated Show resolved Hide resolved
interpreter/src/main/scala/pl/touk/nussknacker/engine/spel/SpelExpressionSuggester.scala Outdated Show resolved Hide resolved
interpreter/src/main/scala/pl/touk/nussknacker/engine/spel/SpelExpressionSuggester.scala Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

updated: #4340

@bartektartanus bartektartanus force-pushed the expression-suggestions-with-typer branch from 40e9de0 to 7fa182c Compare June 2, 2023 17:18
@github-actions github-actions bot added client client main fe ui labels Jun 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

updated: #4340

@bartektartanus bartektartanus force-pushed the expression-suggestions-with-typer branch from 7fa182c to f6329ec Compare June 5, 2023 12:40
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

updated: #4340

@bartektartanus bartektartanus force-pushed the expression-suggestions-with-typer branch from dadb4e5 to cd6a3ec Compare June 5, 2023 22:10
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

updated: #4340

@bartektartanus bartektartanus mentioned this pull request Jun 7, 2023
Closed
@bartektartanus bartektartanus linked an issue Jun 7, 2023 that may be closed by this pull request
#this variable and it's content is not suggested in nested projection/filtering expression #4073
Closed
@bartektartanus bartektartanus force-pushed the expression-suggestions-with-typer branch from e93f216 to 4fb3143 Compare June 7, 2023 13:41
@github-actions github-actions bot mentioned this pull request Jun 7, 2023
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

created: #4356

@bartektartanus bartektartanus force-pushed the expression-suggestions-with-typer branch 2 times, most recently from b03ce28 to 12a600d Compare June 13, 2023 09:42
@github-actions
Copy link
Contributor

created: #4364

@github-actions github-actions bot mentioned this pull request Jun 13, 2023
Closed
@github-actions
Copy link
Contributor

updated: #4364

bartektartanus and others added 4 commits June 13, 2023 14:46
@bartektartanus
Suggestions with Typer
a4b1744 
Co-authored-by: bartektartanus <bartektartanus@users.noreply.github.com>
@bartektartanus
review fix
82e6df5
@bartektartanus
scala 2.12 compilation fix
60c39ab
@bartektartanus
scala 2.12 compilation fix
1a21acc
@bartektartanus bartektartanus force-pushed the expression-suggestions-with-typer branch from 4ebdde0 to f972f05 Compare June 13, 2023 12:46
@bartektartanus bartektartanus force-pushed the expression-suggestions-with-typer branch from f972f05 to edef45e Compare June 13, 2023 12:49
@github-actions
Copy link
Contributor

created: #4366

@github-actions github-actions bot mentioned this pull request Jun 13, 2023
Merged
@github-actions @bartektartanus
Updated snapshots (#4366)
b30397c 
Co-authored-by: bartektartanus <bartektartanus@users.noreply.github.com>
@github-actions
Copy link
Contributor

created: #4367

@github-actions github-actions bot mentioned this pull request Jun 13, 2023
Closed
arkadius
arkadius approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@arkadius arkadius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome feature 🚀

@bartektartanus bartektartanus merged commit d9cfda5 into staging Jun 13, 2023
17 checks passed
@coutoPL coutoPL deleted the expression-suggestions-with-typer branch August 16, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lciolecki lciolecki lciolecki left review comments

@arkadius arkadius arkadius approved these changes

Assignees
No one assigned
Labels
client client main fe docs ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

#this variable and it's content is not suggested in nested projection/filtering expression
3 participants
@bartektartanus @arkadius @lciolecki