Remove isDeployed/isCancelled flags based on lastAction #4353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lciolecki
reviewed
Jun 7, 2023
.../server/src/main/scala/pl/touk/nussknacker/ui/process/deployment/DeploymentServiceImpl.scala
Outdated
Show resolved
Hide resolved
lciolecki
reviewed
Jun 7, 2023
.../server/src/test/scala/pl/touk/nussknacker/ui/process/deployment/DeploymentServiceSpec.scala
Outdated
Show resolved
Hide resolved
gskrobisz
force-pushed
the
move_status_flags
branch
from
7fb87fb
to
d118565
Compare
lciolecki
reviewed
Jun 15, 2023
.../server/src/test/scala/pl/touk/nussknacker/ui/process/deployment/DeploymentServiceSpec.scala
Show resolved
Hide resolved
gskrobisz
force-pushed
the
move_status_flags
branch
from
1444fca
to
9a3aa19
Compare
|
created: #4427 |
|
updated: #4427 |
|
: #4427 |
1 similar comment
|
: #4427 |
gskrobisz
force-pushed
the
move_status_flags
branch
from
ed85e18
to
68ed95e
Compare
gskrobisz
force-pushed
the
move_status_flags
branch
from
7715f64
to
ea61037
Compare
arkadius
reviewed
Jul 12, 2023
extensions-api/src/main/scala/pl/touk/nussknacker/engine/api/deployment/ProcessAction.scala
Show resolved
Hide resolved
arkadius
reviewed
Jul 12, 2023
...rver/src/main/scala/pl/touk/nussknacker/ui/process/repository/ProcessDBQueryRepository.scala
Outdated
Show resolved
Hide resolved
gskrobisz
force-pushed
the
move_status_flags
branch
from
e6cd165
to
6bcea03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Proces(that is the most controversial part of this change)Process.isDeployed/isCancelledmethods (we should not evaluate scenario status from lastAction)DeploymentServiceImpl.checkStateInDeploymentManagerStateStatus flags "isXYZ" are removed in #4350