Chore cleaning and upgrading packages #4466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tch enzyme to a testing library react
# Conflicts: # designer/client/package-lock.json # designer/client/package.json
This reverts commit b77502f.
|
created: #4470 |
Co-authored-by: Dzuming <Dzuming@users.noreply.github.com>
# Conflicts: # designer/client/src/components/graph/NodeUtils.ts # designer/client/src/components/graph/SubprocessSchemaAligner.js # designer/client/test/FragmentSchemaAligner-test.js
…kages' into chore_cleaning_and_upgrading_packages # Conflicts: # designer/client/cypress/e2e/__image_snapshots__/electron/Linux/Expression suggester should display javadocs #0.png
This reverts commit 6569239.
This reverts commit 541249c.
|
created: #4475 |
|
updated: #4475 |
|
created: #4476 |
Co-authored-by: Dzuming <Dzuming@users.noreply.github.com>
JulianWielga
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run build-bundle-analyzercommand/distfolder before webpack application buildreact 18testing-library/reactand remove enzyme and enzyme-based dependencies from our codebaseNOTE:
We cannot fully use React 18 because we cannot change how react is initialized to https://react.dev/reference/react-dom/client/createRoot. For some reason, WindowManagerProvider styles are not correct (the loader after opening a specific scenario node is not centered), we need to take a look at it later.
General observations about bundle size
seems like we should try to remove Bootstrap from our codebase in the future