Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation to SPeL literal conversions #4677

Merged
merged 9 commits into from Sep 18, 2023
Merged

Add validation to SPeL literal conversions #4677

merged 9 commits into from Sep 18, 2023

Conversation

wrzontek
Copy link
Contributor

@wrzontek wrzontek commented Sep 14, 2023 •
edited

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Code formatting checked
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@github-actions github-actions bot added the docs label Sep 14, 2023
@github-actions github-actions bot mentioned this pull request Sep 14, 2023
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023 •
edited

updated: #4684
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

@wrzontek wrzontek changed the title Add validation to spel conversions Add validation to SPeL conversions Sep 14, 2023
arkadius
arkadius approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@arkadius arkadius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One slight detail to fix

lciolecki
lciolecki reviewed Sep 17, 2023
View reviewed changes
build.sbt Outdated Show resolved Hide resolved
lciolecki
lciolecki reviewed Sep 17, 2023
View reviewed changes
docs/Changelog.md Outdated Show resolved Hide resolved
@github-actions github-actions bot mentioned this pull request Sep 18, 2023
Closed
@wrzontek wrzontek changed the title Add validation to SPeL conversions Add validation to SPeL literal conversions Sep 18, 2023
@wrzontek wrzontek merged commit 68dc682 into staging Sep 18, 2023
17 checks passed
@wrzontek wrzontek deleted the validate-spel-conversions branch September 18, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lciolecki lciolecki lciolecki left review comments

@arkadius arkadius arkadius approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wrzontek @arkadius @lciolecki