Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use processingType for validate nad sugesstions api #4697

Merged
merged 2 commits into from Sep 20, 2023
Merged

Use processingType for validate nad sugesstions api #4697

merged 2 commits into from Sep 20, 2023

Conversation

philemone
Copy link
Contributor

The discussion took place in a #4693 MR. It wont be merged as patch to 1.11 since it is API change so I've created this MR to staging instead.

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Code formatting checked
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@github-actions github-actions bot added client client main fe ui docs labels Sep 20, 2023
@philemone philemone mentioned this pull request Sep 20, 2023
Closed
10 tasks
arkadius
arkadius reviewed Sep 20, 2023
View reviewed changes
docs/MigrationGuide.md Outdated Show resolved Hide resolved
arkadius
arkadius approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@arkadius arkadius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added minor comment regarding migration guide

@philemone philemone force-pushed the preview/processing_type_suggestions branch from 9a0887e to d6e8d1a Compare September 20, 2023 14:32
@philemone philemone merged commit e58d397 into staging Sep 20, 2023
17 checks passed
@philemone philemone deleted the preview/processing_type_suggestions branch September 20, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkadius arkadius arkadius approved these changes

Assignees
No one assigned
Labels
client client main fe docs ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@philemone @arkadius