Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: RegExpParameterValidator, trimming SpEL comprehension #4762

Merged
merged 3 commits into from Oct 4, 2023
Merged

Fix: RegExpParameterValidator, trimming SpEL comprehension #4762

merged 3 commits into from Oct 4, 2023

Conversation

lciolecki
Copy link
Contributor

@lciolecki lciolecki commented Oct 2, 2023 •
edited

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Code formatting checked
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@lciolecki lciolecki changed the title Fix: RegExpParameterValidator, trimming SPeL '' Fix: RegExpParameterValidator, trimming SPeL comprehension Oct 2, 2023
@lciolecki lciolecki force-pushed the fix/RegExpParameterValidator branch 3 times, most recently from 430a313 to d56b380 Compare October 2, 2023 19:00
@github-actions github-actions bot mentioned this pull request Oct 2, 2023
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023 •
edited

updated: #4777
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

@lciolecki lciolecki force-pushed the fix/RegExpParameterValidator branch 4 times, most recently from 5550feb to e48a5aa Compare October 2, 2023 20:28
@github-actions github-actions bot added the docs label Oct 3, 2023
@lciolecki lciolecki marked this pull request as ready for review October 3, 2023 08:21
@github-actions github-actions bot added client client main fe ui labels Oct 3, 2023
@lciolecki lciolecki changed the title Fix: RegExpParameterValidator, trimming SPeL comprehension Fix: RegExpParameterValidator, trimming SpEL comprehension Oct 3, 2023
@lciolecki lciolecki force-pushed the fix/RegExpParameterValidator branch 5 times, most recently from dd463ec to a81fe25 Compare October 3, 2023 12:58
@github-actions github-actions bot mentioned this pull request Oct 3, 2023
Closed
@lciolecki lciolecki merged commit 0068c89 into staging Oct 4, 2023
16 of 17 checks passed
@lciolecki lciolecki deleted the fix/RegExpParameterValidator branch October 4, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkadius arkadius arkadius approved these changes

Assignees
No one assigned
Labels
client client main fe docs ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lciolecki @arkadius