Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameter validator string to any refactor #4928

Merged
merged 6 commits into from Nov 13, 2023
Merged

Parameter validator string to any refactor #4928

merged 6 commits into from Nov 13, 2023

Conversation

bartektartanus
Copy link
Contributor

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@bartektartanus bartektartanus mentioned this pull request Oct 23, 2023
Closed
9 tasks
@github-actions github-actions bot mentioned this pull request Oct 23, 2023
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2023 •
edited

updated: #5002
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

raphaelsolarski
raphaelsolarski reviewed Oct 23, 2023
View reviewed changes
build.sbt Outdated Show resolved Hide resolved
@bartektartanus bartektartanus force-pushed the ParameterValidatorStringToAnyRefactor branch 2 times, most recently from 1501d08 to 251d966 Compare October 23, 2023 15:41
@bartektartanus bartektartanus force-pushed the ParameterValidatorStringToAnyRefactor branch 2 times, most recently from 9bae7ec to 58a5afb Compare November 9, 2023 13:43
@github-actions github-actions bot mentioned this pull request Nov 9, 2023
Closed
@bartektartanus bartektartanus force-pushed the ParameterValidatorStringToAnyRefactor branch 2 times, most recently from e2bdd03 to 0622e88 Compare November 9, 2023 16:51
@bartektartanus bartektartanus force-pushed the ParameterValidatorStringToAnyRefactor branch from 2810e09 to abdee4e Compare November 13, 2023 09:10
@github-actions github-actions bot mentioned this pull request Nov 13, 2023
Closed
mslabek
mslabek reviewed Nov 13, 2023
View reviewed changes
Copy link
Member

@mslabek mslabek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some questions and nitpicks. Nice change :)

build.sbt Outdated Show resolved Hide resolved
...a/pl/touk/nussknacker/engine/schemedkafka/source/delayed/DelayedKafkaAvroSourceFactory.scala Show resolved Hide resolved
...er/server/src/main/scala/pl/touk/nussknacker/ui/validation/ScenarioPropertiesValidator.scala Outdated Show resolved Hide resolved
@bartektartanus bartektartanus merged commit b9222b3 into staging Nov 13, 2023
16 checks passed
@bartektartanus bartektartanus deleted the ParameterValidatorStringToAnyRefactor branch November 13, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkadius arkadius arkadius left review comments

@lciolecki lciolecki lciolecki left review comments

@mslabek mslabek mslabek left review comments

@raphaelsolarski raphaelsolarski raphaelsolarski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bartektartanus @arkadius @lciolecki @raphaelsolarski @mslabek