New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NU-983] Add missing validations to base components #4953
Merged
mslabek
merged 37 commits into
staging
from
NU-983/filter-required-expression-validation
Dec 4, 2023
Merged
[NU-983] Add missing validations to base components #4953
mslabek
merged 37 commits into
staging
from
NU-983/filter-required-expression-validation
Dec 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mslabek
force-pushed
the
NU-983/filter-required-expression-validation
branch
2 times, most recently
from
October 29, 2023 15:40
cda1be6
to
9cbaab0
Compare
created: #5129 |
mslabek
changed the title
[NU-983] Required expression validation in filter
[NU-983] Add missing validations to base components
Oct 30, 2023
mslabek
force-pushed
the
NU-983/filter-required-expression-validation
branch
2 times, most recently
from
November 3, 2023 15:06
564dc4f
to
290ee13
Compare
mslabek
force-pushed
the
NU-983/filter-required-expression-validation
branch
from
November 15, 2023 09:20
81787c7
to
2b89ad3
Compare
mslabek
force-pushed
the
NU-983/filter-required-expression-validation
branch
from
November 20, 2023 15:18
2ac22e7
to
40156b4
Compare
mslabek
force-pushed
the
NU-983/filter-required-expression-validation
branch
3 times, most recently
from
November 23, 2023 13:19
17e3acc
to
4ff0994
Compare
mslabek
force-pushed
the
NU-983/filter-required-expression-validation
branch
from
November 27, 2023 22:02
4ff0994
to
832548a
Compare
mslabek
force-pushed
the
NU-983/filter-required-expression-validation
branch
from
November 28, 2023 13:35
a840b44
to
ff38bde
Compare
arkadius
reviewed
Nov 28, 2023
...ter/src/main/scala/pl/touk/nussknacker/engine/compile/nodecompilation/BaseNodeCompiler.scala
Outdated
Show resolved
Hide resolved
...ter/src/main/scala/pl/touk/nussknacker/engine/compile/nodecompilation/BaseNodeCompiler.scala
Outdated
Show resolved
Hide resolved
...ter/src/main/scala/pl/touk/nussknacker/engine/compile/nodecompilation/BaseNodeCompiler.scala
Outdated
Show resolved
Hide resolved
...ter/src/main/scala/pl/touk/nussknacker/engine/compile/nodecompilation/BaseNodeCompiler.scala
Outdated
Show resolved
Hide resolved
...ter/src/main/scala/pl/touk/nussknacker/engine/compile/nodecompilation/BaseNodeCompiler.scala
Outdated
Show resolved
Hide resolved
...ter/src/main/scala/pl/touk/nussknacker/engine/compile/nodecompilation/BaseNodeCompiler.scala
Outdated
Show resolved
Hide resolved
...ter/src/main/scala/pl/touk/nussknacker/engine/compile/nodecompilation/BaseNodeCompiler.scala
Outdated
Show resolved
Hide resolved
mslabek
force-pushed
the
NU-983/filter-required-expression-validation
branch
from
November 29, 2023 13:34
fc9d263
to
bc24811
Compare
…cord fields regardless of expression compilation
Dzuming
reviewed
Dec 1, 2023
arkadius
reviewed
Dec 1, 2023
arkadius
reviewed
Dec 1, 2023
...ter/src/main/scala/pl/touk/nussknacker/engine/compile/nodecompilation/BaseNodeCompiler.scala
Outdated
Show resolved
Hide resolved
arkadius
reviewed
Dec 1, 2023
...ter/src/main/scala/pl/touk/nussknacker/engine/compile/nodecompilation/BaseNodeCompiler.scala
Show resolved
Hide resolved
Dzuming
approved these changes
Dec 1, 2023
# Conflicts: # docs/Changelog.md # interpreter/src/main/scala/pl/touk/nussknacker/engine/compile/nodecompilation/NodeCompiler.scala # interpreter/src/test/scala/pl/touk/nussknacker/engine/compile/NodeDataValidatorSpec.scala
arkadius
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The goal is to make the validation consistent between FE and BE for base components by adding BE validations that are done only on the FE.
Main goal - Bringing base components FE validations to BE
In base components these validations are:
Also, this removes the default Mandatory value validation on the FE if no validator was set. This is going to be removed anyways after removing the FE validators.
Api changes
In MapVariable (and FragmentOuptut) and in Switch the validated parameters are not standard fields and they require their own solutions to be correctly displayed. BE can control under which field the error is displayed by the
fieldName
in theNodeValidationError
object.$fields-${index}-$key
$fields-${index}-$value
Problems
Checklist before merge