Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NU-1061] listener-api depends on extensions-api instead of restmodel #4959

Merged
merged 3 commits into from Nov 2, 2023
Merged

[NU-1061] listener-api depends on extensions-api instead of restmodel #4959

merged 3 commits into from Nov 2, 2023

Conversation

arkadius
Copy link
Member

@arkadius arkadius commented Oct 28, 2023 •
edited by coutoPL

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@arkadius arkadius changed the title [NU-1061] listener-api depends on extensions-api instead of resmodel [NU-1061] listener-api depends on extensions-api instead of restmodel Oct 28, 2023
@github-actions github-actions bot added the docs label Oct 28, 2023
@arkadius arkadius force-pushed the NU-1061-listener-api-restmodel-decoupled branch from 95ce467 to b4071ae Compare October 28, 2023 07:58
@github-actions github-actions bot added client client main fe ui labels Oct 28, 2023
@arkadius arkadius force-pushed the NU-1061-listener-api-restmodel-decoupled branch from 525e1d5 to eaf4ce5 Compare October 28, 2023 09:08
@arkadius arkadius force-pushed the NU-1061-listener-api-restmodel-decoupled branch from eaf4ce5 to b4071ae Compare October 30, 2023 12:28
@github-actions github-actions bot removed ui client client main fe labels Oct 30, 2023
@github-actions github-actions bot mentioned this pull request Oct 30, 2023
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2023 •
edited

updated: #4965
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

coutoPL
coutoPL requested changes Nov 2, 2023
View reviewed changes
Copy link
Member

@coutoPL coutoPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments

...el/src/main/scala/pl/touk/nussknacker/restmodel/validation/ValidatedDisplayableProcess.scala Outdated Show resolved Hide resolved
...rver/src/main/scala/pl/touk/nussknacker/ui/process/repository/ProcessDBQueryRepository.scala Outdated Show resolved Hide resolved
designer/server/src/test/scala/pl/touk/nussknacker/ui/api/helpers/ProcessTestData.scala Outdated Show resolved Hide resolved
designer/server/src/test/scala/pl/touk/nussknacker/ui/process/DBProcessServiceSpec.scala Outdated Show resolved Hide resolved
designer/server/src/test/scala/pl/touk/nussknacker/ui/util/PdfExporterSpec.scala Outdated Show resolved Hide resolved
@arkadius arkadius requested a review from coutoPL November 2, 2023 11:00
coutoPL
coutoPL approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@coutoPL coutoPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkadius arkadius merged commit 2206351 into staging Nov 2, 2023
16 of 17 checks passed
@arkadius arkadius deleted the NU-1061-listener-api-restmodel-decoupled branch November 2, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coutoPL coutoPL coutoPL approved these changes

@lciolecki lciolecki Awaiting requested review from lciolecki

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arkadius @coutoPL