Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NU-1290] Global variables types are removed from communication between BE and FE #5039

Merged
merged 5 commits into from Nov 27, 2023
Merged

[NU-1290] Global variables types are removed from communication between BE and FE #5039

merged 5 commits into from Nov 27, 2023

Conversation

arkadius
Copy link
Member

…

in both directions:

  • They are not returned during validation of scenario
  • They are not passed into node validation and suggestions mechanism

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@github-actions github-actions bot added client client main fe docs ui labels Nov 23, 2023
@arkadius arkadius changed the title [NU-1290] Global variables types are removed from communication betwe… [NU-1290] Global variables types are removed from communication between BE and FE Nov 23, 2023
@arkadius arkadius force-pushed the NU-1290-globalVariables-BE-only branch 3 times, most recently from 0ecd995 to 7f5dd91 Compare November 23, 2023 18:11
@github-actions github-actions bot mentioned this pull request Nov 23, 2023
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 23, 2023 •
edited

updated: #5056
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

@arkadius arkadius force-pushed the NU-1290-globalVariables-BE-only branch from 7f5dd91 to ea3b33d Compare November 23, 2023 18:37
@arkadius
[NU-1290] Global variables types are removed from communication betwe…
21be53c 
…en BE and FE

in both directions:
- They are not returned during validation of scenario
- They are not passed into node validation and suggestions mechanism
@arkadius arkadius force-pushed the NU-1290-globalVariables-BE-only branch from ea3b33d to 21be53c Compare November 23, 2023 19:40
@github-actions @arkadius
Updated snapshots (#5042)
5a058a5 
Co-authored-by: arkadius <arkadius@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Nov 23, 2023
Closed
bartektartanus
bartektartanus reviewed Nov 23, 2023
View reviewed changes
designer/server/src/test/scala/pl/touk/nussknacker/ui/api/ExpressionSuggesterSpec.scala Show resolved Hide resolved
docs/MigrationGuide.md Outdated Show resolved Hide resolved
designer/client/src/http/HttpService.ts Outdated Show resolved Hide resolved
designer/client/test/ProcessUtils-test.js Outdated Show resolved Hide resolved
docs/MigrationGuide.md Outdated Show resolved Hide resolved
@github-actions github-actions bot mentioned this pull request Nov 24, 2023
Closed
@github-actions github-actions bot mentioned this pull request Nov 24, 2023
Closed
@arkadius arkadius merged commit 8de7a5b into staging Nov 27, 2023
16 of 17 checks passed
@arkadius arkadius deleted the NU-1290-globalVariables-BE-only branch November 27, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartektartanus bartektartanus bartektartanus approved these changes

Assignees
No one assigned
Labels
client client main fe docs ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arkadius @bartektartanus