Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NU-1279] fix fragment params visibility in compare #5094

Merged
merged 7 commits into from
Dec 1, 2023
Merged

[NU-1279] fix fragment params visibility in compare #5094

merged 7 commits into from
Dec 1, 2023

Conversation

Dzuming
Copy link
Contributor

@Dzuming Dzuming commented Nov 29, 2023

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@github-actions github-actions bot added client client main fe ui labels Nov 29, 2023
@Dzuming Dzuming changed the base branch from staging to release/1.12 November 29, 2023 14:03
@github-actions github-actions bot mentioned this pull request Nov 29, 2023
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 29, 2023 •
edited

updated: #5110
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

@Dzuming Dzuming marked this pull request as ready for review November 30, 2023 13:16
@github-actions github-actions bot mentioned this pull request Nov 30, 2023
Merged
Dzuming and others added 2 commits December 1, 2023 08:40
@Dzuming
NU-1298 increase threshold for a fragment
484f97f
@github-actions @Dzuming
Updated snapshots (#5110)
6322ad3 
Co-authored-by: Dzuming <Dzuming@users.noreply.github.com>
@Dzuming Dzuming merged commit 9f17d1b into release/1.12 Dec 1, 2023
14 checks passed
@Dzuming Dzuming deleted the NU-1298-fix-fragment-params-visibility-in-compare branch December 1, 2023 10:51
coutoPL pushed a commit that referenced this pull request Dec 4, 2023
@Dzuming @github-actions @coutoPL
[NU-1279] fix fragment params visibility in compare (#5094)
7dd3b6e 
* NU-1279 fix fragment params visibility in compare

* NU-1279 provide e2e test

* Revert "NU-1279 provide e2e test"

This reverts commit 08d3eef.

* Revert "Revert "NU-1279 provide e2e test""

This reverts commit 84c8b00.

* NU-1298 increase threshold for a fragment

* Updated snapshots (#5110)

Co-authored-by: Dzuming <Dzuming@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Dzuming <Dzuming@users.noreply.github.com>
vder pushed a commit that referenced this pull request Dec 6, 2023
@Dzuming @github-actions
[NU-1279] fix fragment params visibility in compare (#5094)
06d5947 
* NU-1279 fix fragment params visibility in compare

* NU-1279 provide e2e test

* Revert "NU-1279 provide e2e test"

This reverts commit 08d3eef.

* Revert "Revert "NU-1279 provide e2e test""

This reverts commit 84c8b00.

* NU-1298 increase threshold for a fragment

* Updated snapshots (#5110)

Co-authored-by: Dzuming <Dzuming@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Dzuming <Dzuming@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulianWielga JulianWielga JulianWielga approved these changes

Assignees
No one assigned
Labels
client client main fe ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Dzuming @JulianWielga