Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NU-1291] Filter model definition by categories on the very beginning on BE side instead of FE #5103

Merged
merged 1 commit into from Dec 4, 2023

Conversation

arkadius
Copy link
Member

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@github-actions github-actions bot added client client main fe docs ui labels Nov 30, 2023
@arkadius arkadius changed the title [NU-1291] ComponentProvider - removed possibility to configure categories [NU-1291] Filter model definition by categories on the very beginning on BE side instead of FE Nov 30, 2023
@arkadius arkadius force-pushed the NU-1291-modeldata-category-aware branch 2 times, most recently from ff4e8ce to b4a2a57 Compare November 30, 2023 14:29
Copy link
Contributor

github-actions bot commented Nov 30, 2023

created: #5139
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

@arkadius arkadius force-pushed the NU-1291-modeldata-category-aware branch from b4a2a57 to 08681d4 Compare December 1, 2023 14:41
@github-actions github-actions bot removed ui client client main fe labels Dec 1, 2023
@arkadius arkadius requested a review from pielas December 1, 2023 14:49
@arkadius arkadius force-pushed the NU-1291-modeldata-category-aware branch from 08681d4 to 8aa608f Compare December 4, 2023 09:30
docs/Changelog.md Outdated Show resolved Hide resolved
docs/MigrationGuide.md Outdated Show resolved Hide resolved
Copy link
Contributor

@pielas pielas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkadius arkadius merged commit b07016a into staging Dec 4, 2023
16 of 17 checks passed
@arkadius arkadius deleted the NU-1291-modeldata-category-aware branch December 4, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants