Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NU-1291] [Security] Processing type data - check read access to category #5141

Merged
merged 3 commits into from Dec 5, 2023
Merged

[NU-1291] [Security] Processing type data - check read access to category #5141

merged 3 commits into from Dec 5, 2023

Conversation

arkadius
Copy link
Member

@arkadius arkadius commented Dec 4, 2023 •
edited by pielas

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@github-actions github-actions bot added the docs label Dec 4, 2023
@arkadius arkadius force-pushed the NU-1291-processingtype-access-check branch from c102f92 to 0382126 Compare December 4, 2023 12:44
@arkadius arkadius changed the title [NU-1291] Processing type data - check read access to category [NU-1291] [Security] Processing type data - check read access to category Dec 4, 2023
@arkadius arkadius requested a review from pielas December 4, 2023 13:14
@arkadius arkadius force-pushed the NU-1291-processingtype-access-check branch from 0382126 to 1b1c073 Compare December 4, 2023 15:14
@github-actions github-actions bot mentioned this pull request Dec 4, 2023
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023

created: #5146
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

pielas
pielas requested changes Dec 4, 2023
View reviewed changes
...r/src/main/scala/pl/touk/nussknacker/ui/process/deployment/DeploymentManagerDispatcher.scala Outdated Show resolved Hide resolved
...r/src/main/scala/pl/touk/nussknacker/ui/process/deployment/DeploymentManagerDispatcher.scala Outdated Show resolved Hide resolved
...ain/scala/pl/touk/nussknacker/ui/process/processingtypedata/ProcessingTypeDataProvider.scala Outdated Show resolved Hide resolved
...ain/scala/pl/touk/nussknacker/ui/process/processingtypedata/ProcessingTypeDataProvider.scala Outdated Show resolved Hide resolved
...ain/scala/pl/touk/nussknacker/ui/process/processingtypedata/ProcessingTypeDataProvider.scala Outdated Show resolved Hide resolved
docs/Changelog.md Outdated Show resolved Hide resolved
designer/server/src/main/scala/pl/touk/nussknacker/ui/services/AppApiHttpService.scala Outdated Show resolved Hide resolved
.../main/scala/pl/touk/nussknacker/ui/statistics/UsageStatisticsReportsSettingsDeterminer.scala Outdated Show resolved Hide resolved
@arkadius
review
defb740
@arkadius
Small enhancements:
61ba8c2 
- throwing UnauthorizedError instead of returning None
- ValueWithPermission easier
@arkadius arkadius force-pushed the NU-1291-processingtype-access-check branch from 9e3af54 to 61ba8c2 Compare December 5, 2023 07:46
@arkadius arkadius requested a review from pielas December 5, 2023 07:46
pielas
pielas approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@pielas pielas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkadius arkadius merged commit 31d491c into staging Dec 5, 2023
9 of 10 checks passed
@arkadius arkadius deleted the NU-1291-processingtype-access-check branch December 5, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pielas pielas pielas approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arkadius @pielas