Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nu 1338 testkit simper result type #5240

Merged
merged 1 commit into from Dec 14, 2023
Merged

Nu 1338 testkit simper result type #5240

merged 1 commit into from Dec 14, 2023

Conversation

arkadius
Copy link
Member

@arkadius arkadius commented Dec 13, 2023 •
edited by coutoPL

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@github-actions github-actions bot added the docs label Dec 13, 2023
@arkadius arkadius force-pushed the NU-1338-testkit-simper-result-type branch from 6521aa5 to f306993 Compare December 13, 2023 21:56
coutoPL
coutoPL approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@coutoPL coutoPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkadius arkadius force-pushed the NU-1338-testkit-simper-result-type branch from f306993 to 1f3003c Compare December 14, 2023 17:05
@arkadius arkadius merged commit 4ee5e61 into staging Dec 14, 2023
2 checks passed
@arkadius arkadius deleted the NU-1338-testkit-simper-result-type branch December 14, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coutoPL coutoPL coutoPL approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arkadius @coutoPL