Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable configuration of fragments via config #5253

Merged
merged 5 commits into from Dec 28, 2023

Conversation

wrzontek
Copy link
Contributor

Describe your changes

Due to the recent expansion of FragmentParameter, the option to alter fragment configuration via config has become largely reduntant. Remove to decrease unnecessary complexity.

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@wrzontek wrzontek changed the title Disable configurtion of fragments via config Disable configuration of fragments via config Dec 18, 2023
@arkadius
Copy link
Member

Please remember about Changelog entry

@github-actions github-actions bot added the docs label Dec 21, 2023
Copy link
Member

@arkadius arkadius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@arkadius arkadius merged commit fdd8802 into staging Dec 28, 2023
17 checks passed
@arkadius arkadius deleted the no-configs-for-fragments branch December 28, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants