New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NU-1400] Legacy categories config removal #5323
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkadius
changed the title
Legacy categories config removal
[NU-1324] Legacy categories config removal
Jan 9, 2024
arkadius
changed the base branch from
staging
to
fragment-component-definition-move
January 9, 2024 09:22
coutoPL
changed the title
[NU-1324] Legacy categories config removal
[NU-1400] Legacy categories config removal
Jan 9, 2024
lciolecki
reviewed
Jan 9, 2024
lciolecki
approved these changes
Jan 9, 2024
arkadius
force-pushed
the
fragment-component-definition-move
branch
from
January 9, 2024 16:09
dd2b9e7
to
6d613bc
Compare
arkadius
force-pushed
the
legacy-categories-config-removal
branch
from
January 9, 2024 16:10
8150074
to
9175413
Compare
arkadius
force-pushed
the
legacy-categories-config-removal
branch
from
January 9, 2024 20:08
9175413
to
f5bb3ad
Compare
updated: #5331 |
arkadius
force-pushed
the
legacy-categories-config-removal
branch
from
January 10, 2024 01:04
ce257ea
to
0aa266e
Compare
coutoPL
reviewed
Jan 10, 2024
...ner/server/src/main/scala/pl/touk/nussknacker/ui/process/ProcessStateDefinitionService.scala
Outdated
Show resolved
Hide resolved
...ner/server/src/main/scala/pl/touk/nussknacker/ui/process/ProcessStateDefinitionService.scala
Show resolved
Hide resolved
coutoPL
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wrzontek
reviewed
Jan 12, 2024
* [#4860](https://github.com/TouK/nussknacker/pull/4860) In file-based configuration, the field `scenarioTypes.<scenarioType>.additionalPropertiesConfig` is renamed to `scenarioTypes.<scenarioType>.scenarioPropertiesConfig` | ||
* [#5077](https://github.com/TouK/nussknacker/pull/5077) In SQL enricher configuration, `connectionProperties` was changed to `dataSourceProperties` | ||
* [#5323](https://github.com/TouK/nussknacker/pull/5323) Support for [the legacy categories configuration format](https://nussknacker.io/documentation/docs/1.12/installation_configuration_guide/DesignerConfiguration/#scenario-type-categories) was removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is merged to 1.14, not 1.13, no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Checklist before merge