Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NU-1400] Legacy categories config removal #5323

Merged
merged 7 commits into from Jan 11, 2024

Conversation

arkadius
Copy link
Member

@arkadius arkadius commented Jan 9, 2024

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@github-actions github-actions bot added the docs label Jan 9, 2024
@arkadius arkadius changed the title Legacy categories config removal [NU-1324] Legacy categories config removal Jan 9, 2024
@arkadius arkadius requested a review from coutoPL January 9, 2024 09:17
@arkadius arkadius changed the base branch from staging to fragment-component-definition-move January 9, 2024 09:22
@coutoPL coutoPL changed the title [NU-1324] Legacy categories config removal [NU-1400] Legacy categories config removal Jan 9, 2024
docs/Changelog.md Outdated Show resolved Hide resolved
@arkadius arkadius force-pushed the fragment-component-definition-move branch from dd2b9e7 to 6d613bc Compare January 9, 2024 16:09
@arkadius arkadius force-pushed the legacy-categories-config-removal branch from 8150074 to 9175413 Compare January 9, 2024 16:10
Base automatically changed from fragment-component-definition-move to staging January 9, 2024 20:07
Copy link
Contributor

github-actions bot commented Jan 9, 2024

updated: #5331
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

@arkadius arkadius force-pushed the legacy-categories-config-removal branch from ce257ea to 0aa266e Compare January 10, 2024 01:04
@arkadius arkadius requested a review from coutoPL January 10, 2024 13:40
Copy link
Member

@coutoPL coutoPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkadius arkadius merged commit 3268538 into staging Jan 11, 2024
15 of 17 checks passed
@arkadius arkadius deleted the legacy-categories-config-removal branch January 11, 2024 08:35
* [#4860](https://github.com/TouK/nussknacker/pull/4860) In file-based configuration, the field `scenarioTypes.<scenarioType>.additionalPropertiesConfig` is renamed to `scenarioTypes.<scenarioType>.scenarioPropertiesConfig`
* [#5077](https://github.com/TouK/nussknacker/pull/5077) In SQL enricher configuration, `connectionProperties` was changed to `dataSourceProperties`
* [#5323](https://github.com/TouK/nussknacker/pull/5323) Support for [the legacy categories configuration format](https://nussknacker.io/documentation/docs/1.12/installation_configuration_guide/DesignerConfiguration/#scenario-type-categories) was removed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is merged to 1.14, not 1.13, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants