Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NU-1149] Validate disabled nodes expressions #5364

Merged
merged 6 commits into from Jan 24, 2024

Conversation

mslabek
Copy link
Member

@mslabek mslabek commented Jan 14, 2024

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

Copy link
Contributor

github-actions bot commented Jan 17, 2024

: #5395
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

@mslabek mslabek force-pushed the NU-1149/disabled-node-validation branch from 1cf84e6 to c685fc5 Compare January 21, 2024 00:35
@mslabek mslabek marked this pull request as ready for review January 22, 2024 08:12
@mslabek mslabek requested a review from arkadius January 22, 2024 10:17
@mslabek mslabek requested a review from wrzontek January 22, 2024 16:00
Co-authored-by: Adrian Matwiejuk <73438286+wrzontek@users.noreply.github.com>
@mslabek mslabek force-pushed the NU-1149/disabled-node-validation branch from a2e8295 to 9db4cbc Compare January 24, 2024 13:01
@mslabek mslabek requested a review from wrzontek January 24, 2024 13:44
@mslabek mslabek merged commit ea112b9 into staging Jan 24, 2024
16 checks passed
@mslabek mslabek deleted the NU-1149/disabled-node-validation branch January 24, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants