Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DictParameterEditor #5371

Merged
merged 25 commits into from Feb 17, 2024
Merged

DictParameterEditor #5371

merged 25 commits into from Feb 17, 2024

Conversation

wrzontek
Copy link
Contributor

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@wrzontek
Merge branch 'staging' into dictEditor
fd18a39 
# Conflicts:
#	designer/server/src/test/scala/pl/touk/nussknacker/ui/validation/UIProcessValidatorSpec.scala
@wrzontek
Dict Query API restoration
6e0e73b
@github-actions github-actions bot added client client main fe ui labels Jan 19, 2024
@wrzontek
Merge remote-tracking branch 'origin/staging' into dictEditor
ec67254 
# Conflicts:
#	components-api/src/main/scala/pl/touk/nussknacker/engine/api/context/ProcessCompilationError.scala
#	designer/server/src/main/scala/pl/touk/nussknacker/ui/server/AkkaHttpBasedRouteProvider.scala
#	designer/server/src/test/scala/pl/touk/nussknacker/ui/api/DefinitionResourcesSpec.scala
#	designer/server/src/test/scala/pl/touk/nussknacker/ui/api/helpers/ProcessTestData.scala
#	designer/server/src/test/scala/pl/touk/nussknacker/ui/validation/UIProcessValidatorSpec.scala
#	interpreter/src/main/scala/pl/touk/nussknacker/engine/compile/ExpressionCompiler.scala
#	interpreter/src/main/scala/pl/touk/nussknacker/engine/compile/Validations.scala
#	interpreter/src/main/scala/pl/touk/nussknacker/engine/definition/model/ModelDefinitionFromConfigCreatorExtractor.scala
@wrzontek
post merge fixes + some PR comments
077c49e
@wrzontek
ut fix
8de339d
@wrzontek
dictionaries use only literal expressions
5c75c6e
@wrzontek
Merge remote-tracking branch 'origin/staging' into dictEditor
fb95006 
# Conflicts:
#	designer/server/src/test/scala/pl/touk/nussknacker/ui/validation/UIProcessValidatorSpec.scala
@wrzontek
fmt
3bea496
@wrzontek
remove todos
0a97660
@wrzontek
simplify withExpressionParsers(modify) into withLabelsDictTyper
7c583de
@wrzontek
introduce Expression.labelWithKey
d274d3b
@wrzontek
update label in ProcessDictSubstitutor
e9b4df3
@wrzontek
Merge remote-tracking branch 'origin/staging' into dictEditor
b195cd3 
# Conflicts:
#	designer/server/src/main/scala/pl/touk/nussknacker/ui/api/DefinitionResources.scala
#	designer/server/src/test/scala/pl/touk/nussknacker/ui/api/DefinitionResourcesSpec.scala
#	designer/server/src/test/scala/pl/touk/nussknacker/ui/api/helpers/ProcessTestData.scala
@wrzontek
merge fix
4b8f343
@wrzontek
don't validate DictParameterEditor using dictRegistry on engine side
dc839e4
@wrzontek
PR comments
94a0753
@wrzontek
Merge remote-tracking branch 'origin/staging' into dictEditor
27a234f 
# Conflicts:
#	designer/server/src/test/scala/pl/touk/nussknacker/test/utils/domain/ProcessTestData.scala
#	designer/server/src/test/scala/pl/touk/nussknacker/ui/api/ComponentApiSpec.scala
#	designer/server/src/test/scala/pl/touk/nussknacker/ui/integration/DictsFlowTest.scala
#	docs/Changelog.md
@wrzontek
post merge fix
96f5090
@wrzontek wrzontek changed the title DictParameterEditor draft DictParameterEditor Feb 16, 2024
@github-actions github-actions bot added the docs label Feb 16, 2024
@wrzontek wrzontek marked this pull request as ready for review February 16, 2024 11:46
@github-actions github-actions bot mentioned this pull request Feb 16, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 16, 2024 •
edited

created: #5563
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

arkadius
arkadius approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@arkadius arkadius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@github-actions github-actions bot mentioned this pull request Feb 16, 2024
Closed
@wrzontek wrzontek merged commit 860a375 into staging Feb 17, 2024
17 checks passed
@wrzontek wrzontek deleted the dictEditor branch February 17, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkadius arkadius arkadius approved these changes

Assignees
No one assigned
Labels
client client main fe docs ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wrzontek @arkadius