New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NU-1408][regression] anonymous user handling in case of Tapir's endpoints #5505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coutoPL
force-pushed
the
bugfix/NU-1408
branch
2 times, most recently
from
February 6, 2024 21:46
79e1d4e
to
5f7b6c1
Compare
coutoPL
force-pushed
the
bugfix/NU-1408
branch
from
February 7, 2024 09:49
cddef74
to
6b6cc24
Compare
…g/NU-1408_tests_improvements
…g/NU-1408_tests_improvements
…ements' into bugfix/NU-1408
mk-software-pl
changed the base branch from
staging
to
refactoring/NU-1408_tests_improvements
February 14, 2024 21:48
Base automatically changed from
refactoring/NU-1408_tests_improvements
to
staging
February 15, 2024 09:59
ForrestFairy
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a question if we should add a note about this to Changelog?
coutoPL
force-pushed
the
bugfix/NU-1408
branch
from
February 15, 2024 10:42
f5c546b
to
45f0201
Compare
mslabek
reviewed
Feb 15, 2024
extensions-api/src/main/scala/pl/touk/nussknacker/security/AuthCredentials.scala
Outdated
Show resolved
Hide resolved
extensions-api/src/main/scala/pl/touk/nussknacker/security/AuthCredentials.scala
Outdated
Show resolved
Hide resolved
security/src/main/scala/pl/touk/nussknacker/ui/security/api/AuthenticationResources.scala
Outdated
Show resolved
Hide resolved
mslabek
approved these changes
Feb 15, 2024
arkadius
reviewed
Feb 15, 2024
...c/main/scala/pl/touk/nussknacker/ui/server/NuAkkaHttpServerInterpreterForTapirPurposes.scala
Outdated
Show resolved
Hide resolved
...c/main/scala/pl/touk/nussknacker/ui/server/NuAkkaHttpServerInterpreterForTapirPurposes.scala
Outdated
Show resolved
Hide resolved
extensions-api/src/main/scala/pl/touk/nussknacker/security/AuthCredentials.scala
Show resolved
Hide resolved
extensions-api/src/main/scala/pl/touk/nussknacker/security/AuthCredentials.scala
Outdated
Show resolved
Hide resolved
security/src/main/scala/pl/touk/nussknacker/ui/security/api/AuthenticationResources.scala
Outdated
Show resolved
Hide resolved
security/src/main/scala/pl/touk/nussknacker/ui/security/api/AuthenticationResources.scala
Outdated
Show resolved
Hide resolved
security/src/main/scala/pl/touk/nussknacker/ui/security/api/AuthenticationResources.scala
Outdated
Show resolved
Hide resolved
utils/test-utils/src/main/scala/pl/touk/nussknacker/test/PatientScalaFutures.scala
Outdated
Show resolved
Hide resolved
coutoPL
force-pushed
the
bugfix/NU-1408
branch
from
February 15, 2024 21:14
0873881
to
0c9a4bc
Compare
arkadius
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Akka-http routes have anonymous user handling when no authorization credentials were passed. The functionality was not ported to Tapir-based endpoints. It's a regression.
This PR adds the functionality to Tapir's endpoints.
Checklist before merge