Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NU-1408][regression] anonymous user handling in case of Tapir's endpoints #5505

Merged
merged 64 commits into from Feb 16, 2024

Conversation

mk-software-pl
Copy link
Contributor

Describe your changes

Akka-http routes have anonymous user handling when no authorization credentials were passed. The functionality was not ported to Tapir-based endpoints. It's a regression.

This PR adds the functionality to Tapir's endpoints.

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@coutoPL coutoPL force-pushed the bugfix/NU-1408 branch 2 times, most recently from 79e1d4e to 5f7b6c1 Compare February 6, 2024 21:46
@github-actions github-actions bot added the docs label Feb 14, 2024
@mk-software-pl mk-software-pl changed the base branch from staging to refactoring/NU-1408_tests_improvements February 14, 2024 21:48
Base automatically changed from refactoring/NU-1408_tests_improvements to staging February 15, 2024 09:59
Copy link
Contributor

@ForrestFairy ForrestFairy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a question if we should add a note about this to Changelog?

Copy link
Member

@arkadius arkadius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@mk-software-pl mk-software-pl merged commit 15cee17 into staging Feb 16, 2024
17 checks passed
@mk-software-pl mk-software-pl deleted the bugfix/NU-1408 branch February 16, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants