Bump Kotlin-related dependencies #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, we bump all Kotlin-related dependencies to recent versions. This includes a Kotlin bump from 1.4 to 1.6, the upgrade of Detekt from 1.14 to 1.20 and the upgrade of Ktlint from 0.39 to 0.45. For Kotlin, instead of depending on its stdlib, Gradle now uses the Kotlin plugin. For tests, the Detekt YAML file was reset from the latest default, then adapted slightly so the expected rules still get triggered, trying to keep it as similar as possible to what it used to be. The NewLineAtEndOfFile rule was improved to point at the last line, instead of the first one, thus the tests were changed accordingly. Ktlint deprecated the use of some of its API, so the processor was updated accordingly. Also, removed deprecated jcenter repository, since it is not in use anymore. In terms of migration/changelog: - Release notes of Detekt, since: https://detekt.dev/docs/introduction/changelog/ - KtLint changelog: https://github.com/pinterest/ktlint/releases
|
Thanks for the submission, we'll review them. In the meantime, can you consider upgrading straight to Kotlin 1.7, which was released recently? |
|
LGTM |
RayanFellah
pushed a commit
to RayanFellah/sputnik
that referenced
this pull request
Jan 28, 2024
* Bump Kotlin-related dependencies With this change, we bump all Kotlin-related dependencies to recent versions. This includes a Kotlin bump from 1.4 to 1.6, the upgrade of Detekt from 1.14 to 1.20 and the upgrade of Ktlint from 0.39 to 0.45. For Kotlin, instead of depending on its stdlib, Gradle now uses the Kotlin plugin. For tests, the Detekt YAML file was reset from the latest default, then adapted slightly so the expected rules still get triggered, trying to keep it as similar as possible to what it used to be. The NewLineAtEndOfFile rule was improved to point at the last line, instead of the first one, thus the tests were changed accordingly. Ktlint deprecated the use of some of its API, so the processor was updated accordingly. Also, removed deprecated jcenter repository, since it is not in use anymore. In terms of migration/changelog: - Release notes of Detekt, since: https://detekt.dev/docs/introduction/changelog/ - KtLint changelog: https://github.com/pinterest/ktlint/releases * Upgrade Kotlin to 1.7.0 Co-authored-by: George Ungureanu - Vranceanu <george.ungureanuvranceanu@imc.com> Co-authored-by: Piotr Jagielski <pjg@touk.pl>
rufuslevi
pushed a commit
to rufuslevi/sputnik
that referenced
this pull request
Mar 12, 2024
* Bump Kotlin-related dependencies With this change, we bump all Kotlin-related dependencies to recent versions. This includes a Kotlin bump from 1.4 to 1.6, the upgrade of Detekt from 1.14 to 1.20 and the upgrade of Ktlint from 0.39 to 0.45. For Kotlin, instead of depending on its stdlib, Gradle now uses the Kotlin plugin. For tests, the Detekt YAML file was reset from the latest default, then adapted slightly so the expected rules still get triggered, trying to keep it as similar as possible to what it used to be. The NewLineAtEndOfFile rule was improved to point at the last line, instead of the first one, thus the tests were changed accordingly. Ktlint deprecated the use of some of its API, so the processor was updated accordingly. Also, removed deprecated jcenter repository, since it is not in use anymore. In terms of migration/changelog: - Release notes of Detekt, since: https://detekt.dev/docs/introduction/changelog/ - KtLint changelog: https://github.com/pinterest/ktlint/releases * Upgrade Kotlin to 1.7.0 Co-authored-by: George Ungureanu - Vranceanu <george.ungureanuvranceanu@imc.com> Co-authored-by: Piotr Jagielski <pjg@touk.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, we bump all Kotlin-related dependencies to recent
versions. This includes a Kotlin bump from 1.4 to 1.6, the upgrade of
Detekt from 1.14 to 1.20 and the upgrade of Ktlint from 0.39 to 0.45.
For Kotlin, instead of depending on its stdlib, Gradle now uses the
Kotlin plugin.
For tests, the Detekt YAML file was reset from the latest default, then
adapted slightly so the expected rules still get triggered, trying to
keep it as similar as possible to what it used to be. The
NewLineAtEndOfFile rule was improved to point at the last line, instead
of the first one, thus the tests were changed accordingly.
Also, removed deprecated jcenter repository, since it is not in use
anymore.
In terms of migration/changelog:
Release notes of Detekt:
https://detekt.dev/docs/introduction/changelog/
KtLint changelog:
https://github.com/pinterest/ktlint/releases