GitHub status api #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems fine to me. Can you please rebase? |
|
Merged intermediate commits. |
|
Nice! How can it be tested? |
| /** | ||
| * post comment for github pull request | ||
| */ | ||
| private void postComment(Pull pull, int lineNo, String comment, String commitSha, String filename) { |
There was a problem hiding this comment.
This is not called anywhere?
added 2 commits
July 4, 2015 10:22
| import java.io.StringWriter; | ||
| import java.io.Writer; | ||
|
|
||
| public class ContentRenderer { |
There was a problem hiding this comment.
maybe it could be package protected?
pjagielski
force-pushed
the
github-status-api
branch
from
a5a25b2
to
cc38085
Compare
pjagielski
force-pushed
the
github-status-api
branch
from
cc38085
to
6e098cf
Compare
| HOST("connector.host", "Connector server host", "localhost"), | ||
| PORT("connector.port", "Connector server port", "80"), | ||
| PATH("connector.path", "Connector server path", ""), | ||
| USE_HTTPS("connector.useHttps", "Connector use https?", "false"), | ||
| USERNAME("connector.username", "Connector server username", "user"), | ||
| PASSWORD("connector.password", "Connector server password", "password"), | ||
| PROJECT_KEY("connector.projectKey", "Connector server projectKey", null), | ||
| REPOSITORY_SLUG("connector.repositorySlug", "Connector server repositorySlug", null), | ||
| OWNER("connector.owner", "Connector server owner", null), |
There was a problem hiding this comment.
I know it was some time ago and this PR is merged, but this change will break clients who have connector.repositorySlug in their configuration files.
Moreover, not all elements have been changed: https://github.com/TouK/sputnik/search?utf8=%E2%9C%93&q=%22connector.repositorySlug%22+%22connector.projectKey%22&type=Code
rufuslevi
pushed a commit
to rufuslevi/sputnik
that referenced
this pull request
Mar 12, 2024
GitHub status api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github connector for Sputnik.
There is still an issue with jcabi-github. Waiting for jcabi/jcabi-github#1102 being merged.