fix: add typing-extensions to dependencies
#227
Merged
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlondonobo
changed the title
typing-extensions to dependencies
PrettyWood
requested changes
Apr 6, 2024
lukapeschke
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Thank you! @PrettyWood about the TYPE_CHECKING guard: I agree it would be best, but typing_extensions is pulled in by a lot of python packages, so I guess it's fine like this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of This PR
This PR incorporates
typing-extensionsintofastexcel's dependencies, addressing Issue #226.Outcomes
This update resolves a subtle bug in the
polarslibrary'sread_excelfunction, specifically when utilizing thecalamineengine.Before this change, attempting to use the
calamineengine would trigger an erroneous message frompolars, indicating thatfastexcelwas not installed, despite its presence. This issue stemmed from the absence of thetyping-extensionsdependency.Testing
All test are passing after running
make test.