Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vqb): added substring step #1058

Merged
merged 5 commits into from Sep 7, 2021
Merged

feat(vqb): added substring step #1058

merged 5 commits into from Sep 7, 2021

Conversation

Sanix-Darker
Copy link
Member

@Sanix-Darker Sanix-Darker commented Sep 7, 2021

What

  • VQB snowflake substring step
    • unittest
    • fixtures tests
      • pandas
      • snowflake
    • substring step
      • normal indexes
      • negatives indexes

Overview

Peek 2021-09-07 11-48

@Sanix-Darker
Copy link
Member Author

@codecov
Copy link

codecov bot commented Sep 7, 2021

Codecov Report

Merging #1058 (99a3bac) into master (3a4f6e7) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1058      +/-   ##
==========================================
+ Coverage   98.71%   98.72%   +0.01%     
==========================================
  Files         187      190       +3     
  Lines        5207     5272      +65     
  Branches      784      788       +4     
==========================================
+ Hits         5140     5205      +65     
  Misses         67       67              
Impacted Files Coverage Δ
weaverbird/src/lib/dates.ts 100.00% <0.00%> (ø)
weaverbird/src/components/Step.vue 100.00% <0.00%> (ø)
weaverbird/src/components/Pipeline.vue 100.00% <0.00%> (ø)
weaverbird/src/components/DataTypesMenu.vue 100.00% <0.00%> (ø)
weaverbird/src/components/ActionToolbarSearch.vue 100.00% <0.00%> (ø)
...verbird/src/components/DeleteConfirmationModal.vue 100.00% <0.00%> (ø)
...erbird/src/components/stepforms/StepFormHeader.vue 100.00% <0.00%> (ø)
...ird/src/components/stepforms/widgets/InputDate.vue 100.00% <0.00%> (ø)
...ird/src/components/stepforms/widgets/InputText.vue 100.00% <0.00%> (ø)
...rd/src/components/stepforms/StatisticsStepForm.vue 100.00% <0.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a4f6e7...99a3bac. Read the comment docs.

Copy link
Contributor

@raphaelvignes raphaelvignes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Encore une nouvelle step, Merci !
J'ai un doute sur la gestion des index < 0, j'attends ton retour pour valider.

@Sanix-Darker Sanix-Darker merged commit 250e731 into master Sep 7, 2021
@Sanix-Darker Sanix-Darker deleted the feat/step-extract branch September 7, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants