refactor(ui): move to /ui folder, switch to vite for build #1581
Conversation
|
Your Render PR Server URL is https://weaverbird-playground-pr-1581.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cdimssirrk0bq63khge0. |
Note: the naming-convention may need some configuration
The store was not shared otherwise!
Use the alpha v7 to have manager and preview built by vite
I will not make them all! It's way too much work, we should do them piece by piece, only keeping ones that are relevant
These components are exposed in the lib, so it's important to have means to see them work in isolation. Also fix a few typing issues
Codecov ReportBase: 98.41% // Head: 0.00% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1581 +/- ##
==========================================
- Coverage 98.41% 0 -98.42%
==========================================
Files 218 0 -218
Lines 6171 0 -6171
Branches 963 0 -963
==========================================
- Hits 6073 0 -6073
+ Misses 98 0 -98 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
OK, I think it's good enough for now. I prefer merging this ASAP to unblock the ability to do releases.
|
| @@ -60,7 +60,7 @@ import VariableInput from './VariableInput.vue'; | |||
| FAIcon, | |||
| }, | |||
| }) | |||
| export default class AutocompleteWidget extends Mixins(FormWidget) { | |||
| export default class AutocompleteWidget extends FormWidget { | |||
There was a problem hiding this comment.
Ah oui t'as carrément enlever l'usage de Mixins! Bonne idée ^^
Part of #912 was to move everything UI-related into its own folder, so the root stays cleans.
I took this opportunity to also switch the build system to vite (it became necessary because typescript needed to be updated too, and the rollup plugins were not following).
Sorry for this faaaaaaat PR, tat contained a lot of sed/replacements in order to clean all the build errors.
TODO:
repair storybookswitch tests to vitestadapt github actions and sonar