Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix :: use $addFields instead of $project in rename and newcolumn steps #75

Merged
merged 2 commits into from
Apr 10, 2019
Merged

Fix :: use $addFields instead of $project in rename and newcolumn steps #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
895f361
Use instead of
vdestraitt Apr 9, 2019
98c0f75
Fix format
vdestraitt Apr 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/lib/translators/mongo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,12 @@ const mapper: StepMatcher<MongoStep> = {
domain: step => ({ $match: { domain: step.domain } }),
filter: filterstepToMatchstep,
select: step => ({ $project: fromkeys(step.columns, 1) }),
rename: step => ({ $project: { [step.newname]: `$${step.oldname}` } }),
rename: step => [
{ $addFields: { [step.newname]: `$${step.oldname}` } },
{ $project: { [step.oldname]: 0 } },
],
delete: step => ({ $project: fromkeys(step.columns, 0) }),
newcolumn: step => ({ $project: { [step.column]: step.query } }),
newcolumn: step => ({ $addFields: { [step.column]: step.query } }),
aggregate: transformAggregate,
custom: step => step.query,
};
Expand Down
66 changes: 54 additions & 12 deletions tests/unit/mongo.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,27 +18,56 @@ describe('Pipeline to mongo translator', () => {
expect(querySteps).toEqual([{ $match: { domain: 'test_cube' } }]);
});

it('can generate match steps', () => {
it('can generate select steps', () => {
const pipeline: Array<PipelineStep> = [
{ name: 'domain', domain: 'test_cube' },
{ name: 'select', columns: ['Region'] },
{ name: 'rename', oldname: 'Region', newname: 'zone' },
{ name: 'delete', columns: ['Manager'] },
{ name: 'select', columns: ['Manager', 'Region'] },
];
const querySteps = mongo36translator.translate(pipeline);
expect(querySteps).toEqual([
{ $match: { domain: 'test_cube' } },
{
name: 'newcolumn',
column: 'id',
query: { $concat: ['$country', ' - ', '$Region'] },
$project: {
Manager: 1,
Region: 1,
},
},
]);
});

it('can generate delete steps', () => {
const pipeline: Array<PipelineStep> = [
{ name: 'domain', domain: 'test_cube' },
{ name: 'delete', columns: ['Manager', 'Region'] },
];
const querySteps = mongo36translator.translate(pipeline);
expect(querySteps).toEqual([
{ $match: { domain: 'test_cube' } },
{
$project: {
Region: 1,
zone: '$Region',
Manager: 0,
id: { $concat: ['$country', ' - ', '$Region'] },
Region: 0,
},
},
]);
});

it('can generate rename steps', () => {
const pipeline: Array<PipelineStep> = [
{ name: 'domain', domain: 'test_cube' },
{ name: 'rename', oldname: 'Region', newname: 'zone' },
];
const querySteps = mongo36translator.translate(pipeline);
expect(querySteps).toEqual([
{ $match: { domain: 'test_cube' } },
{
$addFields: {
zone: '$Region',
},
},
{
$project: {
Region: 0,
},
},
]);
Expand Down Expand Up @@ -108,9 +137,9 @@ describe('Pipeline to mongo translator', () => {
const pipeline: Array<PipelineStep> = [
{ name: 'domain', domain: 'test_cube' },
{ name: 'filter', column: 'Manager', value: 'Pierre' },
{ name: 'delete', columns: ['Manager'] },
{ name: 'select', columns: ['Region'] },
{ name: 'rename', oldname: 'Region', newname: 'zone' },
{ name: 'delete', columns: ['Manager'] },
{ name: 'newcolumn', column: 'id', query: { $concat: ['$country', ' - ', '$Region'] } },
{
name: 'custom',
Expand All @@ -122,9 +151,22 @@ describe('Pipeline to mongo translator', () => {
{ $match: { domain: 'test_cube', Manager: 'Pierre' } },
{
$project: {
Manager: 0,
Region: 1,
},
},
{
$addFields: {
zone: '$Region',
Manager: 0,
},
},
{
$project: {
Region: 0,
},
},
{
$addFields: {
id: { $concat: ['$country', ' - ', '$Region'] },
},
},
Expand Down