Update to goutils 0.5.0 #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cszatmary
force-pushed
the
goutils-0.5.0
branch
from
ced424e
to
7380b4b
Compare
cszatmary
force-pushed
the
goutils-0.5.0
branch
from
f6455ec
to
abdc755
Compare
|
@l0rdcafe would appreciate a review on this when you have a chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates goutils to v0.5.0 which switches to use the new
slogpackage in the standard library. As a result, the minimum go version required is 1.21.See TouchBistro/goutils#17 for more context on the goutils changes.
Demo
I tested cannon locally and the output still works as before.
As a bonus, cannon now handles if
stderris not a TTY, e.g. redirected to a file.