Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provided examples contain bugs/glitches #6

Closed
dkarbayev opened this issue Sep 13, 2017 · 4 comments
Closed

Provided examples contain bugs/glitches #6

dkarbayev opened this issue Sep 13, 2017 · 4 comments

Comments

@dkarbayev
Copy link

When I start interactive unwinding and cancel it by releasing my finger before threshold is passed, transition becomes broken. Please see following video explanations: https://www.dropbox.com/s/v6vb2gczopew1sw/Transition.mov

@toineheuvelmans
Copy link
Contributor

Hi @dkarbayev, thank you for submitting this, I really appreciate that you made the video which clearly demonstrates some issues.
We are currently a bit low on resources to address these right on (as goes for the other open issues 😬), but I will do my best to get time for it on our planning a.s.a.p.

@p3scobar
Copy link

p3scobar commented Nov 6, 2017

/Pods/Transition/Transition/Classes/AnimationLayer.swift:37:42: Static var 'full' is internal and cannot be referenced from a default argument value

public init(range: AnimationRange = .full, timingParameters: AnimationTimingParameters, animation: @escaping AnimationFunction) {
    self.range = range
    self.timingParameters = timingParameters
    self.animation = animation
}

// Any idea how to fix this??? Thanks in advance.

@toineheuvelmans
Copy link
Contributor

@dkarbayev
I have addressed the built-in transition animations, which incorrectly removed the visible view when the transition was cancelled.
The glitches (jumps) that are particularly apparent in the ModaltransitionsExample oddly enough seem to be specific to iOS 11 – I first tried to reproduce on iOS 10 but without luck. The issue occurs when a UIViewPropertyAnimator is reversed and continued. Apparently this is an unaddressed regression since iOS 11: https://openradar.appspot.com/34674968
I have created a temporary "fix" that continues the animation by specifying a linear timing curve, instead of none (when none are specified, the originial timing parameters should be used). This seems to avoid the jumping in the animation.
See more here: https://stackoverflow.com/questions/46406670/uiviewpropertyanimator-different-behaviour-on-ios10-and-ios11-reversing-an-anima

@toineheuvelmans
Copy link
Contributor

@p3scobar
I have adjusted the access level of that property, as well as some others. Please create a separate issue in the future such that related comments and actions stay organized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants