radxa-RockPi4: Fix USB keyboard not working

[jirutka]

Note: On ROCK Pi 4B+, the keyboard must be connected to one of the blue USB ports.

Fixes #147

[samueldr]

This change AFAICT should only change the operating system boot order, it shouldn't affect USB functionality in other ways. Unless for some reason looking for a USB boot device works around a problem.

Have you tested the upcoming update (#178) to see if there is some issues that got solved by upstream? There might be, considering other RK3399 had some USB-related issues fixed by it.

Note that it would be undesirable to prefer booting operating system form USB within Tow-Boot. The order is to first boot internal storage, then external storage, on a "gradient". E.g. eMMC is internal, NVMe is internal, SD is kinda internal, USB is not internal. [though yes, currently rockchip targets would prefer SD over NVMe.]

[jirutka]

This change AFAICT should only change the operating system boot order, it shouldn't affect USB functionality in other ways.

Yeah, it’s weird, but it really fixed the problem with USB keyboard.

Have you tested the upcoming update (#178) to see if there is some issues that got solved by upstream?

Yes, that was the first thing I did.

Note that it would be undesirable to prefer booting operating system form USB within Tow-Boot.

I know, it’s suboptimal but still better than the current state in which Tow-Boot is unusable on this device. I’ll try to find another way though.

[jirutka]

Okay, I found a better way, CONFIG_PREBOOT="usb start". I’ve also backported a patch from u-boot (u-boot/u-boot@d5daa02) to fix a reboot loop occuring with some USB devices.

[samueldr]

Notes to self: the changes to drivers/usb/host/xhci-ring.c are part of 2022.07, so the patch is not needed.

The radxa-rockpi4 still doesn't enable PREBOOT with usb start, so this will be needed to be addressed.

[samueldr]

sneaky!

I found "this patch", and got confused seeing it was accepted and merged in 2020.

Note to anyone missing the sneaky bits: this is an edited patch for another board.

We probably should instead move this to Tow-Boot config, since as-this-is it won't be inherited by the 4C, since it uses a different defconfig.

(Still notes to me)