Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repair ZoomOut click event bug #16

Merged
merged 1 commit into from May 29, 2014
Merged

Conversation

daimajia
Copy link
Contributor

int zoom out transformer
when the previous slider zoom out, it still on the above layer of current slide ( just transparent ). When you want to catch the click event, the previous slider will get it instead of current.

So, we have to do another thing to make it disappear. move it to the left.

(I 'm not sure if i describe it clear. you can try to add click event to each slider , and to see it )
:-D

@ToxicBakery
Copy link
Owner

I think this is fine but it is worth noting that the more direct fix is to use onInterceptTouchEvent() for these types of issues.

ToxicBakery added a commit that referenced this pull request May 29, 2014
ZoomOut fragments are shifted offscreen at the end of the transform to prevent touch intercepts on the previous fragment in the pager.
@ToxicBakery ToxicBakery merged commit d7fd49c into ToxicBakery:master May 29, 2014
@daimajia
Copy link
Contributor Author

Oh fine, I just met this problem and fix it by that way.

so I send a pull request.

Thank you anyway for this library and your hard work.

@daimajia
Copy link
Contributor Author

Hi, thanks for your hard work.

I integrated this library to one of my project.

https://github.com/daimajia/AndroidImageSlider I made some change to make it compatible with Android 2.2+.
Anyway, thanks!

@ToxicBakery
Copy link
Owner

No problem, glad you got what you needed out of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants