Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream FiraCode drops OTF #89

Open
zraffer opened this issue Jun 30, 2020 · 3 comments
Open

Upstream FiraCode drops OTF #89

zraffer opened this issue Jun 30, 2020 · 3 comments

Comments

@zraffer
Copy link

zraffer commented Jun 30, 2020

(currently) the Ligaturizer is based on usage of OTF variants of FiraCode

recently the upstream has dropped generating the OTFs into distr directory, thus making usage of Ligaturizer impossible against decent versions of Fira Code

the source issue: tonsky/FiraCode#939

@gaplo917
Copy link
Contributor

gaplo917 commented Aug 7, 2020

@zraffer This is not only a OTF variant issues.

The sad news is FiraCode changed the way of building the ligatures tonsky/FiraCode#1100 (comment)

All hyphen and equals-based arrows, underscores and numbersigns were removed as individual characters in 4. They are now built from segments to allow for infinite-length arrows

The current implementation of Ligaturizer use individual characters to build the ligatures that means it only could support up to FiraCode v3.

Without doing the extra implementation of handling FiraCode v4/v5 's segments and just convert .ttf to .otf, the result would become gaplo917/Ligatured-Hack#3

@akhilesh-balaji
Copy link

Is there a way to just get the new ligatures in Fira Code 3 and up, then? I'm more concerned about getting the new and updated ligatures than the incredibly long arrows that it supports.

@ToxicFrog
Copy link
Owner

The issue isn't just with incredibly long arrows; it's that to support those arrows, Fira 4+ has fundamentally changed the way ligatures are stored in the font. So we could probably update to Fira 3, and get those ligatures, but Fira 4 or higher won't work without a significant redesign even if we don't care about infinite-length arrows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants