Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest release missing many Fira Code ligatures #3

Closed
swrobel opened this issue Jun 16, 2020 · 3 comments
Closed

Latest release missing many Fira Code ligatures #3

swrobel opened this issue Jun 16, 2020 · 3 comments

Comments

@swrobel
Copy link

swrobel commented Jun 16, 2020

HackLigatured-v3.003+FC5.2+JBMv1.0.6
macOS 10.14.6
Tested in both VSCode & Atom

Showing the Fira showcase (I've tested both the CCG & regular versions, and they are the same):
Screen Shot 2020-06-16 at 7 40 47 AM

Stock Fira Code 5.2:
Screen Shot 2020-06-16 at 7 44 00 AM

Compare vs latest JBM:
Screen Shot 2020-06-16 at 7 41 09 AM

@swrobel swrobel changed the title Latest release missing many Fira Code glyphs Latest release missing many Fira Code ligatures Jun 16, 2020
@gaplo917
Copy link
Owner

@swrobel Thanks for reporting!

@gaplo917
Copy link
Owner

gaplo917 commented Jun 18, 2020

After some investigations, I checked that .ttf -> .otf conversion is okays.

Seems like FIRA Code v5 changed the way(standard?) to add the ligatures. That's why a portion of ligatures are affected.

Need more time to see how to fix.

gaplo917 added a commit that referenced this issue Jul 15, 2020
house keeping on python code style
gaplo917 added a commit that referenced this issue Jul 15, 2020
@gaplo917
Copy link
Owner

@swrobel
According to the comment of Fira Code author, Fira code changed the way to add ligatures.

This change added lots of difficulties in extracting ligatures from Fira Code. The fastest way to get the correct Hack font patched with Fira Code is to fallback to Fira Code v3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants