Skip to content

Commit

Permalink
‼️ BREAKING: Remove NameplateSCT
Browse files Browse the repository at this point in the history
  • Loading branch information
Toxicom committed Apr 24, 2024
1 parent b81423e commit 325b778
Show file tree
Hide file tree
Showing 6 changed files with 3 additions and 119 deletions.
1 change: 1 addition & 0 deletions Core/Changelog/6.5.9.lua
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ TXUI.Changelog["6.5.9"] = {
HOTFIX = true,
CHANGES = {
"* Breaking changes",
"Remove " .. F.String.NameplateSCT() .. " profiles",

"* New features",
TXUI.Title
Expand Down
Binary file removed Media/Backgrounds/Installer/NameplateSCT.blp
Binary file not shown.
1 change: 0 additions & 1 deletion Media/Core.lua
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,6 @@ F.AddMedia("installer", "Details")
F.AddMedia("installer", "Plater")
F.AddMedia("installer", "BigWigs")
F.AddMedia("installer", "WeakAuras")
F.AddMedia("installer", "NameplateSCT")
F.AddMedia("installer", "OmniCD")
F.AddMedia("installer", "WarpDeplete")
F.AddMedia("installer", "Vertical")
Expand Down
8 changes: 2 additions & 6 deletions Modules/Installer/Dialog.lua
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ function IS:Dialog()
local addOns = {
OmniCD = I.Media.Installer.OmniCD,
WarpDeplete = I.Media.Installer.WarpDeplete,
NameplateSCT = I.Media.Installer.NameplateSCT,
}

for addOnName, imagePath in pairs(addOns) do
Expand Down Expand Up @@ -461,8 +460,6 @@ function IS:Dialog()
button:SetScript("OnClick", function()
PF["Apply" .. addonName .. "Profile"]()
self:ShowStepComplete(F.String.ToxiUI(addonName) .. " profile installed.")
-- no need to reload for NSCT
if addonName ~= "NameplateSCT" then self.reloadRequired = true end
end)
buttonIndex = buttonIndex + 1
end
Expand All @@ -471,9 +468,9 @@ function IS:Dialog()
installFrame.SubTitle:SetText(F.String.ToxiUI("Additional AddOns"))

installFrame.Desc1:SetText(TXUI.Title .. " offers extra profiles for commonly used AddOns.")
installFrame.Desc2:SetText("Currently supported AddOns: " .. F.String.OmniCD() .. ", " .. F.String.WarpDeplete() .. ", " .. F.String.NameplateSCT())
installFrame.Desc2:SetText("Currently supported AddOns: " .. F.String.OmniCD() .. ", " .. F.String.WarpDeplete())

if not F.IsAddOnEnabled("OmniCD") and not F.IsAddOnEnabled("WarpDeplete") and not F.IsAddOnEnabled("NameplateSCT") then
if not F.IsAddOnEnabled("OmniCD") and not F.IsAddOnEnabled("WarpDeplete") then
installFrame.Desc3:SetText(
F.String.Warning("Warning: ") .. "Looks like you don't have any of the extra AddOns installed. Don't worry, you can still fully experience " .. TXUI.Title .. "!"
)
Expand All @@ -491,7 +488,6 @@ function IS:Dialog()

InstallOptionalAddOn("OmniCD", F.String.OmniCD())
InstallOptionalAddOn("WarpDeplete", F.String.WarpDeplete())
InstallOptionalAddOn("NameplateSCT", F.String.NameplateSCT("NSCT"))
end,

-- Completed Page
Expand Down
111 changes: 0 additions & 111 deletions Modules/Profiles/NameplateSCT.lua

This file was deleted.

1 change: 0 additions & 1 deletion Modules/Profiles/Profiles.xml
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,4 @@
<Script file='Plater.lua' />
<Script file='WarpDeplete.lua' />
<Script file='OmniCD.lua' />
<Script file='NameplateSCT.lua' />
</Ui>

2 comments on commit 325b778

@Yakrel
Copy link

@Yakrel Yakrel commented on 325b778 Apr 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder what's the reason for it?

@Toxicom
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder what's the reason for it?

Half the users of ToxiUI do not use it and even I started to dislike it myself.

https://toxiui.com/articles/additional-addons-feedback-overview/

Also, it's bugged and still nothing has been done about it: Justw8/NameplateSCT#28

Please sign in to comment.