-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Per-user config implementation #9
base: trunk
Are you sure you want to change the base?
Conversation
ced3b09
to
163cc2c
Compare
163cc2c
to
603d8c7
Compare
This seems to be well documented and working fine. I can now create a .hex-file for my TS10 with all my preferred settings without having to actually configure them after flashing (new) firmware, thank you! |
I don't think this is (completely) correct? From his documentation I read the following:
And as far as I can tell it works as expected. When doing this in my case with |
Hey, thanks for the comments. Indeed, the global user customizations are included first followed by the model-specific ones, so you can have a combination of customized defaults common to all lights and model-specific settings. I'm sure there are some scenarios that this approach cannot handle, but so far this is working well for me. |
Yeah, I've seen that just a second later. That's why I had removed my comment immediately. |
Here's a proposed implementation for the per-user customization functionality mentioned in the README. That's a brilliant idea.
I think my approach is better than just adding the custom user directory at the beginning of INCLUDES as suggested by a comment in build.sh, as this allows one to override individual settings without having to replicate the entire config-defaults.h and/or anduril.h.
I don't know if this is at all what you had in mind but let me know what you think!